From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nicolas Pitre <nico@cam.org>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays.
Date: Wed, 09 Jan 2008 09:06:56 +0100 [thread overview]
Message-ID: <478480A0.5030907@viscovery.net> (raw)
In-Reply-To: <7vk5mjmo4f.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>
>> Having said that, I'd actually prefer to stay with variable-sized arrays
>> if they prove portable enough because we don't need the handful of free()s
>> on function exits. Junio, if you like I can resend patch 2/2 using
>> variable-sized arrays.
>
> As an old fashoned git myself, and given the fact that the
> possible prefix and suffix are small number of short constant
> strings, I actually prefer a simpler-and-more-stupid approach.
>
> sideband.c | 18 +++++++++++++-----
> 1 files changed, 13 insertions(+), 5 deletions(-)
Thanks, your version works well here, too, as a replacement of my two patches.
-- Hannes
next prev parent reply other threads:[~2008-01-09 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:24 [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays Johannes Sixt
2008-01-08 17:01 ` Nicolas Pitre
2008-01-09 7:34 ` Johannes Sixt
2008-01-09 7:53 ` Junio C Hamano
2008-01-09 8:06 ` Johannes Sixt [this message]
2008-01-09 19:14 ` Nicolas Pitre
2008-01-08 17:41 ` Junio C Hamano
2008-01-08 19:59 ` Nicolas Pitre
2008-01-08 20:13 ` Junio C Hamano
2008-01-08 20:44 ` Nicolas Pitre
2008-01-09 7:26 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478480A0.5030907@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).