From: "Roger C. Soares" <rogersoares@intelinet.com.br>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.
Date: Sat, 12 Jan 2008 01:02:19 -0200 [thread overview]
Message-ID: <47882DBB.2000308@intelinet.com.br> (raw)
In-Reply-To: <200801110046.41786.robin.rosenberg.lists@dewire.com>
Robin Rosenberg escreveu:
> I pushed my doc-branch as pu, you can look at it. My intention is take a look again
> and then push it as master if there are no objections. Is it ok and good to flags
> public stuff without javadoc as an error (tip pu commit)?
>
> The abbr commit patch is already pushed to master.
>
Looks good to me. You actually took some time to explain things, it will
be usefull, thanks!
If we really want to document all the public methods then I think it's
nice to flag it's absence as an error. It would have made me document
GitResourceNode.getContentIdentifier(), it's now one more comment for
you to add before pushing to master ;)
[]s,
Roger.
next prev parent reply other threads:[~2008-01-12 3:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 1:15 [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor Roger C. Soares
2008-01-08 22:12 ` Robin Rosenberg
2008-01-09 1:33 ` Roger C. Soares
2008-01-10 23:46 ` Robin Rosenberg
2008-01-12 3:02 ` Roger C. Soares [this message]
2008-01-12 3:37 ` Roger C. Soares
2008-01-12 15:44 ` Robin Rosenberg
2008-01-13 21:02 ` Roger C. Soares
2008-01-13 23:54 ` javadoc (was [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.) Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47882DBB.2000308@intelinet.com.br \
--to=rogersoares@intelinet.com.br \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).