From: Sam Vilain <sam@vilain.net>
To: Nicolas Pitre <nico@cam.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Pierre Habouzit <madcoder@debian.org>,
Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Marco Costalba <mcostalba@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: Decompression speed: zip vs lzo
Date: Sat, 12 Jan 2008 16:06:45 +1300 [thread overview]
Message-ID: <47882EC5.2080406@vilain.net> (raw)
In-Reply-To: <alpine.LFD.1.00.0801112125470.3054@xanadu.home>
Nicolas Pitre wrote:
> Sorry to rain on your parade, but to me 6-10% time saving is not a clear
> win at all, given the equal increase in repository size. This is simply
> not worth it.
Agree.
> And a 50% time saving on an operation, such a git log, which takes less
> than 2 seconds in absolute time, is not worth the repo size increase
> either.
Disagree. Going as much as twice as fast for many history operations
for 10% added space sounds like a clear win to me. We can easily agree
to disagree though - making it a disabled by default config option
allows the user to unroll their packs if they want.
> Going from 2 seconds down to one second doesn't make enough of
> a user experience difference.
What do you mean? 1 second waiting is far better than 2 seconds
waiting. And the mmap optimizations have not even begun yet - that
could result in boosts from zero-copy, such as a lighter VM footprint.
> If git blame was to go from 10 seconds down to 4 then I'd say this is a
> clear win. But this is not the case.
This is an awesome boost! Everything feels snappier already :)
maia:~/src/perl.clean$ time git-log | LANG=C wc
288927 894027 8860916
real 0m0.839s
user 0m0.824s
sys 0m0.144s
maia:~/src/perl.clean$ cd ../perl.clean.loose/
maia:~/src/perl.clean.loose$ time git-log | LANG=C wc
288927 894027 8860916
real 0m0.515s
user 0m0.504s
sys 0m0.136s
maia:~/src/perl.clean.loose$ du -sk .git/objects/pack/
113484 .git/objects/pack/
maia:~/src/perl.clean.loose$ cd -
/home/samv/src/perl.clean
maia:~/src/perl.clean$ du -sk .git/objects/pack/
107040 .git/objects/pack/
maia:~/src/perl.clean$
Want me to try this on kde.git?
Sam.
next prev parent reply other threads:[~2008-01-12 3:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 22:01 Decompression speed: zip vs lzo Marco Costalba
2008-01-09 22:55 ` Junio C Hamano
2008-01-09 23:23 ` Sam Vilain
2008-01-09 23:31 ` Johannes Schindelin
2008-01-10 1:02 ` Sam Vilain
2008-01-10 5:02 ` Sam Vilain
2008-01-10 9:16 ` Pierre Habouzit
2008-01-10 20:39 ` Nicolas Pitre
2008-01-10 21:01 ` Linus Torvalds
2008-01-10 21:30 ` Nicolas Pitre
2008-01-11 8:57 ` Pierre Habouzit
2008-01-10 21:45 ` Sam Vilain
2008-01-10 22:03 ` Linus Torvalds
2008-01-10 22:28 ` Sam Vilain
2008-01-10 22:56 ` Linus Torvalds
2008-01-11 1:01 ` Sam Vilain
2008-01-11 2:10 ` Linus Torvalds
2008-01-11 6:29 ` Sam Vilain
2008-01-11 7:05 ` Sam Vilain
2008-01-11 16:03 ` Linus Torvalds
2008-01-12 1:52 ` Sam Vilain
2008-01-12 2:32 ` Nicolas Pitre
2008-01-12 3:06 ` Sam Vilain [this message]
2008-01-12 16:09 ` Nicolas Pitre
2008-01-12 16:44 ` Johannes Schindelin
2008-01-12 4:46 ` Junio C Hamano
2008-01-10 21:51 ` Marco Costalba
2008-01-10 22:01 ` Sam Vilain
2008-01-10 22:18 ` Nicolas Pitre
2008-01-11 9:45 ` Pierre Habouzit
2008-01-11 14:27 ` Nicolas Pitre
2008-01-11 14:18 ` Morten Welinder
2008-01-10 3:41 ` Nicolas Pitre
2008-01-10 6:55 ` Marco Costalba
2008-01-10 11:45 ` Marco Costalba
2008-01-10 12:12 ` Johannes Schindelin
2008-01-10 12:18 ` Marco Costalba
2008-01-10 19:34 ` Dana How
2008-01-09 23:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47882EC5.2080406@vilain.net \
--to=sam@vilain.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=mcostalba@gmail.com \
--cc=nico@cam.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).