From: Johannes Sixt <j.sixt@viscovery.net>
To: Charles Bailey <charles@hashpling.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Be more careful about updating refs
Date: Thu, 17 Jan 2008 11:52:23 +0100 [thread overview]
Message-ID: <478F3367.8050307@viscovery.net> (raw)
In-Reply-To: <20080117091558.GA8341@hashpling.org>
Charles Bailey schrieb:
> I'm assuming that this original patch and the test update turned into
> the following commit in master:
>
> c3b0dec509fe136c5417422f31898b5a4e2d5e02 is first bad commit
>
> I just thought I should warn you that this seems (git bisect tells me
> so) to have caused a failure in t9301-fast-export.sh on my Mac OS X
> 10.4.11 machine although I haven't yet had the time to investigate
> why.
I observed the same (on Windows). The reason is that above-mentioned
commit introduces a call to parse_objects(). But by the time that
fast-import calls write_ref_sha1() (and, hence, this new parse_objects())
it has not yet written a pack file, and parse_objects() fails. I don't
have a clue how to fix this short of reverting the commit.
-- Hannes
next prev parent reply other threads:[~2008-01-17 10:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 23:50 Be more careful about updating refs Linus Torvalds
2008-01-16 0:02 ` Linus Torvalds
2008-01-16 19:52 ` Junio C Hamano
2008-01-17 9:15 ` Charles Bailey
2008-01-17 10:52 ` Johannes Sixt [this message]
2008-01-17 11:01 ` Charles Bailey
2008-01-17 12:41 ` Johannes Sixt
2008-01-17 12:58 ` Johannes Schindelin
2008-01-17 13:07 ` Charles Bailey
2008-01-18 1:43 ` Junio C Hamano
2008-01-18 2:01 ` Junio C Hamano
2008-01-18 2:13 ` Shawn O. Pearce
2008-01-18 2:25 ` Junio C Hamano
2008-01-18 2:33 ` Shawn O. Pearce
2008-01-18 2:58 ` Shawn O. Pearce
2008-01-18 3:18 ` Shawn O. Pearce
2008-01-18 3:22 ` Shawn O. Pearce
[not found] ` <20080118035700.GA3458@spearce.org>
2008-01-18 4:27 ` [PATCH] Fix random fast-import errors when compiled with NO_MMAP Linus Torvalds
2008-01-18 8:42 ` Charles Bailey
2008-01-18 17:08 ` Linus Torvalds
2008-01-19 3:25 ` Junio C Hamano
2008-01-19 3:55 ` Linus Torvalds
2008-01-21 3:57 ` Shawn O. Pearce
2008-01-18 6:10 ` Junio C Hamano
2008-01-21 4:10 ` Shawn O. Pearce
2008-01-18 7:53 ` Johannes Sixt
2008-01-18 9:26 ` Charles Bailey
2008-01-18 9:36 ` Junio C Hamano
2008-01-18 9:45 ` Charles Bailey
2008-01-18 10:57 ` Junio C Hamano
2008-01-18 2:30 ` Be more careful about updating refs Shawn O. Pearce
2008-01-17 10:56 ` Charles Bailey
2008-01-16 0:29 ` Junio C Hamano
2008-01-16 0:42 ` Linus Torvalds
2008-01-16 1:11 ` Junio C Hamano
2008-01-23 22:53 ` Sam Vilain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478F3367.8050307@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).