git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Piatyszek <ediap@users.sourceforge.net>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Ryan Anderson <ryan@michonline.com>
Subject: Re: [BUG] git send-email brakes patches with very long lines
Date: Thu, 17 Jan 2008 14:26:48 +0100	[thread overview]
Message-ID: <478F5798.6020405@users.sourceforge.net> (raw)
In-Reply-To: <478F5478.7000200@users.sourceforge.net>

* Adam Piatyszek [17 I 2008 14:13]:
> The incorrect line wrapping with an exclamation mark is exactly at 990 
> column. Is there any limitation of the line size for text/plain messages?

Replying to myself again:

RFC2822 (Internet Message Format) states:

   2.1.1. Line Length Limits

     There are two limits that this standard places on the number of
     characters in a line. Each line of characters MUST be no more than
     998 characters, and SHOULD be no more than 78 characters, excluding
     the CRLF.

RFC2821 (Simple Mail Transfer Protocol) states:

   4.5.3.1 Size limits and minimums
   [...]
   text line
     The maximum total length of a text line including the <CRLF> is 1000
     characters (not counting the leading dot duplicated for
     transparency).  This number may be increased by the use of SMTP
     Service Extensions.


Now, the question is. Don't you think that "git send-email" should at 
least warn users that they are trying to send emails with patches that 
will be broken at the end?

BR,
/Adam


-- 
.:.  Adam Piatyszek (ediap)  .:.....................................:.
.:.  ediap@users.sourceforge.net  .:................................:.

  reply	other threads:[~2008-01-17 13:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 10:10 [BUG] git send-email brakes patches with very long lines Adam Piatyszek
2008-01-17 13:13 ` Adam Piatyszek
2008-01-17 13:26   ` Adam Piatyszek [this message]
2008-01-17 15:32     ` Jeff King
2008-01-18  7:47       ` [PATCH] git-send-email.perl: check for lines longer than 998 characters Adam Piątyszek
2008-01-18  8:12         ` Johannes Sixt
2008-01-18  9:42           ` Adam Piatyszek
2008-01-18 10:01             ` Johannes Sixt
2008-01-18 10:08               ` Junio C Hamano
2008-01-18 10:37                 ` Adam Piatyszek
2008-01-18 11:01                   ` Junio C Hamano
2008-01-18 14:16                 ` Jeff King
2008-01-18 14:19                   ` [PATCH 1/3] send-email: detect invocation errors earlier Jeff King
2008-01-18 14:19                   ` [PATCH 2/3] send-email: validate patches before sending anything Jeff King
2008-01-18 15:09                     ` Johannes Sixt
2008-01-18 19:09                       ` Jeff King
2008-01-18 17:39                     ` Jay Soffian
2008-01-18 19:12                       ` Jeff King
2008-01-18 14:20                   ` [PATCH 3/3] send-email: add no-validate option Jeff King
2008-01-18 20:57                   ` [PATCH] git-send-email.perl: check for lines longer than 998 characters Junio C Hamano
2008-01-18 21:30                     ` Jeff King
2008-01-20 22:35                     ` Adam Piatyszek
2008-01-20 22:53                       ` Jeff King
2008-01-21 10:21                         ` Adam Piatyszek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478F5798.6020405@users.sourceforge.net \
    --to=ediap@users.sourceforge.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ryan@michonline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).