git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-commit: add a prepare-commit-msg hook
Date: Fri, 18 Jan 2008 16:51:19 +0100	[thread overview]
Message-ID: <4790CAF7.5010908@gnu.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0801181545530.5731@racer.site>


>> The prepare-commit-msg hook is run whenever a "fresh" commit message 
>> (i.e. not one taken from another commit with -c) is shown in the editor. 
>> It can modify the commit message in-place and/or abort the commit.
>>
>> While the default hook just adds a Signed-Off-By line at the bottom of 
>> the commit messsage, the hook is more intended to build a template for 
>> the commit message following project standards.
> 
> Would it not be much better for that hook to verify that the template has 
> not been added?

I fail to parse this.

> Or would not be yet even better to use the commit.template config 
> variable, which was intended for that purpose?

The template might not necessarily be fixed, for example it could be 
preloaded with the list of modified files.  See the cover letter for an 
example.

Paolo

  reply	other threads:[~2008-01-18 15:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 14:51 [PATCH] git-commit: add a prepare-commit-msg hook Paolo Bonzini
2008-01-18 15:47 ` Johannes Schindelin
2008-01-18 15:51   ` Paolo Bonzini [this message]
2008-01-18 16:06     ` Johannes Schindelin
2008-01-18 16:37       ` Paolo Bonzini
2008-01-18 18:06         ` Johannes Schindelin
2008-01-18 18:51           ` Paolo Bonzini
2008-01-18 19:01           ` Benoit Sigoure
2008-01-18 19:05 ` Alex Riesen
2008-01-18 19:46   ` Paolo Bonzini
2008-01-18 21:08     ` Alex Riesen
2008-01-18 22:05 ` Junio C Hamano
2008-01-19  9:32   ` Paolo Bonzini
2008-01-19 11:20     ` Johannes Schindelin
2008-01-19 15:41       ` Benoit Sigoure
2008-01-19 16:04       ` Paolo Bonzini
2008-01-20 22:28       ` Junio C Hamano
2008-01-21  6:16         ` Paolo Bonzini
2008-01-21 11:04           ` Johannes Schindelin
2008-01-21 12:14             ` Paolo Bonzini
2008-01-21 12:46               ` Johannes Schindelin
2008-01-21 12:59                 ` Paolo Bonzini
2008-01-21 22:44                   ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2008-01-21 14:27 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4790CAF7.5010908@gnu.org \
    --to=bonzini@gnu.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).