git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Include rev-list options in git-log manpage.
Date: Fri, 18 Jan 2008 17:37:11 +0100	[thread overview]
Message-ID: <4790D5B7.2000508@viscovery.net> (raw)
In-Reply-To: <20080118161714.GS29972@genesis.frugalware.org>

Miklos Vajna schrieb:
>  Documentation/git-log.txt          |    6 +-
>  Documentation/git-rev-list.txt     |  358 +-----------------------------------
>  Documentation/rev-list-options.txt |  364 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 367 insertions(+), 361 deletions(-)
>  create mode 100644 Documentation/rev-list-options.txt

Had you used format-patch -C then the patch would have been shorter by
~240 lines. And it would have been immediately obvious that you have put
this inside ifndef::gitlog[] brackets:

> +ifndef::git-log[]
> +--first-parent::
> +	Follow only the first parent commit upon seeing a merge
> +	commit.  This option can give a better overview when
> +	viewing the evolution of a particular topic branch,
> +	because merges into a topic branch tend to be only about
> +	adjusting to updated upstream from time to time, and
> +	this option allows you to ignore the individual commits
> +	brought in to your history by such a merge.
> +endif::git-log[]

I wonder why these brackets are necessary. This text applies to git-log,
too, no? Can't you just remove that paragraph from git-log.txt?

-- Hannes

  reply	other threads:[~2008-01-18 16:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 21:44 [PATCH] Include rev-list options in git-log manpage Miklos Vajna
2008-01-18  7:21 ` Junio C Hamano
2008-01-18 16:17   ` Miklos Vajna
2008-01-18 16:37     ` Johannes Sixt [this message]
2008-01-18 17:18       ` Miklos Vajna
2008-01-18 19:50         ` Junio C Hamano
2008-01-18 19:51         ` Junio C Hamano
2008-01-18 22:50           ` Miklos Vajna
2008-01-18 22:58             ` Miklos Vajna
2008-01-18 23:12               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4790D5B7.2000508@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).