From: Markus Elfring <Markus.Elfring@web.de>
To: git@vger.kernel.org
Cc: Eric Wong <e@80x24.org>, Derrick Stolee <stolee@gmail.com>
Subject: coccinelle: simplify hashmap.cocci?
Date: Tue, 12 Nov 2019 15:40:06 +0100 [thread overview]
Message-ID: <4790d483-bcb8-57f0-5c69-912a814ddade@web.de> (raw)
Hello,
I would like to comment implementation details from
the commit 12878c83516e3b82f31a20f1b5431b7ff607a8db ("coccicheck: detect hashmap_entry.hash assignment").
1. Would you occasionally like to try a change specification out
like the following?
-HME.hash =
+hashmap_entry_init(&HME,
E
+)
;
2. How do you think about to use a code variant (for the semantic patch language)
which can work without a regular expression for the exclusion of a single item?
identifier f != hashmap_entry_init;
Regards,
Markus
reply other threads:[~2019-11-12 14:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4790d483-bcb8-57f0-5c69-912a814ddade@web.de \
--to=markus.elfring@web.de \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).