git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brandon Casey <casey@nrlssc.navy.mil>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list
Date: Wed, 30 Jan 2008 19:35:21 -0600	[thread overview]
Message-ID: <47A125D9.2070105@nrlssc.navy.mil> (raw)
In-Reply-To: <alpine.LSU.1.00.0801310048350.23907@racer.site>

Johannes Schindelin wrote:
> Hi,
> 
> On Wed, 30 Jan 2008, Brandon Casey wrote:
> 
>> This command requires a revision to be specified on the command line, so 
>> remove '--default HEAD' from the arguments to git rev-list. They are 
>> unnecessary.
> 
> But I thought that you wanted "git filter-branch --msg-filter=rot13" to 
> work on HEAD by default?

I do. But isn't that inconsistent with "git filter-branch" does _not_ work
on HEAD by default and instead prints out usage information?

If I do:

	git filter-branch -d /tmp/git_temp

and it is successful, I think I would also expect this to succeed:

	git filter-branch

So, I think the "operates on HEAD" by default is consistent with what other
git tools do, but I think it is not consistent for filter-branch to sometimes
operate on HEAD by default and sometimes error with usage information.

Disclaimer: I have only used filter-branch for two tasks.

-brandon

  reply	other threads:[~2008-01-31  1:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 19:33 [PATCH] filter-branch: assume HEAD if no revision supplied Brandon Casey
2008-01-30 20:35 ` Johannes Schindelin
2008-01-30 21:03   ` Junio C Hamano
2008-01-30 23:35     ` Brandon Casey
2008-01-31  0:13       ` [PATCH 1/2] filter-branch: only print usage information when no arguments supplied Brandon Casey
2008-01-31  1:34         ` Junio C Hamano
2008-01-31  2:05           ` Brandon Casey
2008-01-31  2:44             ` Junio C Hamano
     [not found]       ` <1201738186-28132-1-git-send-email-casey@nrlssc.navy.mil>
2008-01-31  0:15         ` [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list Brandon Casey
2008-01-31  0:49           ` Johannes Schindelin
2008-01-31  1:35             ` Brandon Casey [this message]
2008-01-31  9:17               ` Andreas Ericsson
2008-01-31  9:27                 ` Junio C Hamano
2008-01-31 11:07                   ` Johannes Schindelin
2008-01-31  0:16       ` [PATCH] filter-branch: assume HEAD if no revision supplied Johannes Schindelin
2008-01-31  0:20         ` Brandon Casey
2008-01-31  0:41       ` [PATCH] filter-branch docs: remove brackets so not to imply revision arg is optional Brandon Casey
2008-01-31  1:22         ` Junio C Hamano
2008-01-31  1:53           ` Johannes Schindelin
2008-01-31 16:29           ` Brandon Casey
2008-01-31 21:53             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A125D9.2070105@nrlssc.navy.mil \
    --to=casey@nrlssc.navy.mil \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).