From: Paolo Bonzini <bonzini@gnu.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook
Date: Tue, 05 Feb 2008 16:16:44 +0100 [thread overview]
Message-ID: <47A87DDC.5030708@gnu.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0802051500190.8543@racer.site>
Johannes Schindelin wrote:
> Hi,
>
> On Tue, 5 Feb 2008, Paolo Bonzini wrote:
>
>> The hook is not suppressed by the --no-verify option, and the
>> exit status is ignored by git.
>
> Umm. Should the exit status really be ignored? What _use_ would it be
> then?
None; in the previous version I used an exit status of 1 to kill the
commit. But since this hook, unlike others, is meant to prepare things
for the user, the hook itself was not suppressed by --no-verify, only
checking the exit status. Junio thought it was a mess, so I now
completely ignore the exit status.
I just wrote the above sentence because prepare-commit-msg is the only
git-commit hook whose exit status is ignored.
Paolo
next prev parent reply other threads:[~2008-02-05 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 10:01 [PATCH-v2 1/4] git-commit: support variable number of hook arguments Paolo Bonzini
2008-02-05 10:01 ` [PATCH-v2 2/4] git-commit: set GIT_EDITOR=: if editor will not be launched Paolo Bonzini
2008-02-05 10:01 ` [PATCH-v2 3/4] git-commit: Refactor creation of log message Paolo Bonzini
2008-02-05 10:01 ` [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook Paolo Bonzini
2008-02-05 15:01 ` Johannes Schindelin
2008-02-05 15:16 ` Paolo Bonzini [this message]
2008-02-05 15:21 ` Johannes Schindelin
2008-02-05 15:26 ` Paolo Bonzini
2008-02-05 20:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A87DDC.5030708@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).