From: Brandon Casey <casey@nrlssc.navy.mil>
To: ae@op5.se
Cc: Nicolas Pitre <nico@cam.org>, Git Mailing List <git@vger.kernel.org>
Subject: [PATCH 2/2] pack-objects: Default to zero threads, meaning auto-assign to #cpus
Date: Mon, 11 Feb 2008 20:59:09 -0600 [thread overview]
Message-ID: <47B10B7D.2030702@nrlssc.navy.mil> (raw)
In-Reply-To: <1202784078-23700-1-git-send-email-casey@nrlssc.navy.mil>
Additionally, update some tests for which the multi-threaded result
differs from the single-threaded result and the single-threaded
result is expected.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
Two of the tests in t5300-pack-object.sh failed when multiple
threads were used. My fix was to set --threads=1 for all pack-objects
calls. I didn't look into it any further than that. All other tests
passed.
-brandon
builtin-pack-objects.c | 2 +-
t/t5300-pack-object.sh | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
index 5c55c11..743de52 100644
--- a/builtin-pack-objects.c
+++ b/builtin-pack-objects.c
@@ -70,7 +70,7 @@ static int progress = 1;
static int window = 10;
static uint32_t pack_size_limit, pack_size_limit_cfg;
static int depth = 50;
-static int delta_search_threads = 1;
+static int delta_search_threads = 0;
static int pack_to_stdout;
static int num_preferred_base;
static struct progress *progress_state;
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index cd3c149..16ee940 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -35,7 +35,7 @@ test_expect_success \
test_expect_success \
'pack without delta' \
- 'packname_1=$(git pack-objects --window=0 test-1 <obj-list)'
+ 'packname_1=$(git pack-objects --threads=1 --window=0 test-1 <obj-list)'
rm -fr .git2
mkdir .git2
@@ -66,7 +66,7 @@ cd "$TRASH"
test_expect_success \
'pack with REF_DELTA' \
'pwd &&
- packname_2=$(git pack-objects test-2 <obj-list)'
+ packname_2=$(git pack-objects --threads=1 test-2 <obj-list)'
rm -fr .git2
mkdir .git2
@@ -96,7 +96,7 @@ cd "$TRASH"
test_expect_success \
'pack with OFS_DELTA' \
'pwd &&
- packname_3=$(git pack-objects --delta-base-offset test-3 <obj-list)'
+ packname_3=$(git pack-objects --threads=1 --delta-base-offset test-3 <obj-list)'
rm -fr .git2
mkdir .git2
@@ -271,7 +271,7 @@ test_expect_success \
test_expect_success \
'honor pack.packSizeLimit' \
'git config pack.packSizeLimit 200 &&
- packname_4=$(git pack-objects test-4 <obj-list) &&
+ packname_4=$(git pack-objects --threads=1 test-4 <obj-list) &&
test 3 = $(ls test-4-*.pack | wc -l)'
test_done
--
1.5.4.1.40.gdb90
next prev parent reply other threads:[~2008-02-12 2:59 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 17:28 [PATCH] RFC: git lazy clone proof-of-concept Jan Holesovsky
2008-02-08 18:03 ` Nicolas Pitre
2008-02-09 14:25 ` Jan Holesovsky
2008-02-09 22:05 ` Mike Hommey
2008-02-09 23:38 ` Nicolas Pitre
2008-02-10 7:23 ` Marco Costalba
2008-02-10 12:08 ` Johannes Schindelin
2008-02-10 16:46 ` David Symonds
2008-02-10 17:45 ` Johannes Schindelin
2008-02-10 19:45 ` Nicolas Pitre
2008-02-10 20:32 ` Johannes Schindelin
2008-02-08 18:14 ` Harvey Harrison
2008-02-09 14:27 ` Jan Holesovsky
2008-02-08 18:20 ` Johannes Schindelin
2008-02-08 18:49 ` Mike Hommey
2008-02-08 19:04 ` Johannes Schindelin
2008-02-09 15:06 ` Jan Holesovsky
2008-02-08 19:00 ` Jakub Narebski
2008-02-08 19:26 ` Jon Smirl
2008-02-08 20:09 ` Nicolas Pitre
2008-02-11 10:13 ` Andreas Ericsson
2008-02-12 2:55 ` [PATCH 1/2] pack-objects: Allow setting the #threads equal to #cpus automatically Brandon Casey
2008-02-12 5:53 ` Andreas Ericsson
[not found] ` <1202784078-23700-1-git-send-email-casey@nrlssc.navy.mil>
2008-02-12 2:59 ` Brandon Casey [this message]
2008-02-12 4:57 ` [PATCH 2/2] pack-objects: Default to zero threads, meaning auto-assign to #cpus Nicolas Pitre
2008-02-08 20:19 ` [PATCH] RFC: git lazy clone proof-of-concept Harvey Harrison
2008-02-08 20:24 ` Jon Smirl
2008-02-08 20:25 ` Harvey Harrison
2008-02-08 20:41 ` Jon Smirl
2008-02-09 15:27 ` Jan Holesovsky
2008-02-10 3:10 ` Nicolas Pitre
2008-02-10 4:59 ` Sean
2008-02-10 5:22 ` Nicolas Pitre
2008-02-10 5:35 ` Sean
2008-02-11 1:42 ` Jakub Narebski
2008-02-11 2:04 ` Nicolas Pitre
2008-02-11 10:11 ` Jakub Narebski
2008-02-10 9:34 ` Joachim B Haga
2008-02-10 16:43 ` Johannes Schindelin
2008-02-10 17:01 ` Jon Smirl
2008-02-10 17:36 ` Johannes Schindelin
2008-02-10 18:47 ` Johannes Schindelin
2008-02-10 19:42 ` Nicolas Pitre
2008-02-10 20:11 ` Jon Smirl
2008-02-12 20:37 ` Johannes Schindelin
2008-02-12 21:05 ` Nicolas Pitre
2008-02-12 21:08 ` Linus Torvalds
2008-02-12 21:36 ` Jon Smirl
2008-02-12 21:59 ` Linus Torvalds
2008-02-12 22:25 ` Linus Torvalds
2008-02-12 22:43 ` Jon Smirl
2008-02-12 23:39 ` Linus Torvalds
2008-02-12 21:25 ` Jon Smirl
2008-02-14 19:20 ` Johannes Schindelin
2008-02-14 20:05 ` Jakub Narebski
2008-02-14 20:16 ` Nicolas Pitre
2008-02-14 21:04 ` Johannes Schindelin
2008-02-14 21:59 ` Jakub Narebski
2008-02-14 23:38 ` Johannes Schindelin
2008-02-14 23:51 ` Brian Downing
2008-02-14 23:57 ` Brian Downing
2008-02-15 0:08 ` Johannes Schindelin
2008-02-15 1:41 ` Nicolas Pitre
2008-02-17 8:18 ` Shawn O. Pearce
2008-02-17 9:05 ` Junio C Hamano
2008-02-17 18:44 ` Nicolas Pitre
2008-02-15 1:07 ` Jakub Narebski
2008-02-15 9:43 ` Jan Holesovsky
2008-02-14 21:08 ` Brandon Casey
2008-02-15 9:34 ` Jan Holesovsky
2008-02-10 19:50 ` Nicolas Pitre
2008-02-14 19:41 ` Brandon Casey
2008-02-14 19:58 ` Johannes Schindelin
2008-02-14 20:11 ` Nicolas Pitre
2008-02-11 1:20 ` Jakub Narebski
2008-02-08 20:16 ` Johannes Schindelin
2008-02-08 21:35 ` Jakub Narebski
2008-02-08 21:52 ` Johannes Schindelin
2008-02-08 22:03 ` Mike Hommey
2008-02-08 22:34 ` Johannes Schindelin
2008-02-08 22:50 ` Mike Hommey
2008-02-08 23:14 ` Johannes Schindelin
2008-02-08 23:38 ` Mike Hommey
2008-02-09 21:20 ` Jan Hudec
2008-02-09 15:54 ` Jan Holesovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B10B7D.2030702@nrlssc.navy.mil \
--to=casey@nrlssc.navy.mil \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).