git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Langhoff <martin@catalyst.net.nz>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: Re: [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments
Date: Tue, 19 Feb 2008 05:33:31 +1300	[thread overview]
Message-ID: <47B9B35B.7040200@catalyst.net.nz> (raw)
In-Reply-To: <alpine.LSU.1.00.0802181624490.30505@racer.site>

Johannes Schindelin wrote:
> Note that for this reason, only the "File:" output -- which does not show 
> slashes, but only the basenames -- is used to match the files.  We need 
> the full path in the git repository, though, to apply the patches.

Yes - that's ugly. We have a couple of options

 - Run cvs status once per directory we touch. Use -l tomake it
non-recursive. It will be a tad slower/chattier.

 - Parse the 'Repository revision:' line to find out what path on the
server matches our repo 'root'.

> Thanks.  I am confident that I will have posted another version by the 
> time you come around to review it.

Great! Careful, you might end up enjoying Perl ;-)



m
-- 

  reply	other threads:[~2008-02-18 16:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18  1:31 [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments Johannes Schindelin
2008-02-18  3:03 ` Junio C Hamano
2008-02-18  3:20   ` Junio C Hamano
2008-02-18 15:25     ` Martin Langhoff
2008-02-18 16:27       ` Johannes Schindelin
2008-02-18 16:33         ` Martin Langhoff [this message]
2008-02-18 17:43           ` Johannes Schindelin
2008-02-18 17:55           ` [PATCH v2] " Johannes Schindelin
2008-02-18 17:54   ` [PATCH] " Johannes Schindelin
2008-02-18 18:36     ` Junio C Hamano
2008-02-18 18:50       ` Johannes Schindelin
2008-02-18 18:55       ` Martin Langhoff
2008-02-18 19:42         ` Johannes Schindelin
2008-02-18 20:06           ` Martin Langhoff
2008-02-18 20:29             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B9B35B.7040200@catalyst.net.nz \
    --to=martin@catalyst.net.nz \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).