From: Brandon Casey <casey@nrlssc.navy.mil>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] reflog-delete: parse standard reflog options
Date: Fri, 22 Feb 2008 15:08:59 -0600 [thread overview]
Message-ID: <47BF39EB.5040603@nrlssc.navy.mil> (raw)
In-Reply-To: <47BF1AF2.8070506@nrlssc.navy.mil>
Add support for some standard reflog options such as --dry-run and
--verbose to the reflog delete subcommand.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
Oops.
I forgot to send this patch. The reflog patch set I sent should be
applied on top of this one. Sorry.
-brandon
builtin-reflog.c | 24 +++++++++++++++++++++---
1 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/builtin-reflog.c b/builtin-reflog.c
index 8af75bc..77f70a6 100644
--- a/builtin-reflog.c
+++ b/builtin-reflog.c
@@ -14,6 +14,8 @@
static const char reflog_expire_usage[] =
"git-reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
+static const char reflog_delete_usage[] =
+"git-reflog delete [--verbose] [--dry-run] <refs>...";
static unsigned long default_reflog_expire;
static unsigned long default_reflog_expire_unreachable;
@@ -425,12 +427,28 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
struct cmd_reflog_expire_cb cb;
int i, status = 0;
- if (argc < 2)
- return error("Nothing to delete?");
-
memset(&cb, 0, sizeof(cb));
for (i = 1; i < argc; i++) {
+ const char *arg = argv[i];
+ if (!strcmp(arg, "--dry-run") || !strcmp(arg, "-n"))
+ cb.dry_run = 1;
+ else if (!strcmp(arg, "--verbose"))
+ cb.verbose = 1;
+ else if (!strcmp(arg, "--")) {
+ i++;
+ break;
+ }
+ else if (arg[0] == '-')
+ usage(reflog_delete_usage);
+ else
+ break;
+ }
+
+ if (argc - i < 1)
+ return error("Nothing to delete?");
+
+ for ( ; i < argc; i++) {
const char *spec = strstr(argv[i], "@{");
unsigned char sha1[20];
char *ep, *ref;
--
1.5.4.2.267.g38ea
next prev parent reply other threads:[~2008-02-22 21:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 10:59 What's cooking in git.git (topics) Junio C Hamano
2008-02-03 21:43 ` Johannes Schindelin
2008-02-05 9:37 ` Junio C Hamano
2008-02-05 10:24 ` Jakub Narebski
2008-02-06 9:31 ` Junio C Hamano
2008-02-07 2:03 ` Junio C Hamano
2008-02-07 5:05 ` Jeff King
2008-02-07 9:43 ` Lars Hjemli
2008-02-07 10:32 ` Jakub Narebski
2008-02-10 10:48 ` Junio C Hamano
2008-02-10 16:29 ` Jakub Narebski
2008-02-10 16:48 ` Johannes Schindelin
2008-02-10 22:09 ` Junio C Hamano
2008-02-10 22:09 ` Junio C Hamano
2008-02-12 7:24 ` Junio C Hamano
2008-02-12 9:57 ` reflog-delete, was " Johannes Schindelin
2008-02-17 3:59 ` Junio C Hamano
2008-02-17 12:41 ` Jeff King
2008-02-17 13:52 ` Jakub Narebski
2008-02-17 18:59 ` Junio C Hamano
2008-02-17 22:01 ` Jakub Narebski
2008-02-18 0:37 ` Junio C Hamano
2008-02-18 1:05 ` Jakub Narebski
2008-02-17 15:48 ` Matthias Kestenholz
2008-02-17 18:10 ` Junio C Hamano
2008-02-17 18:22 ` Jeff King
2008-02-17 20:28 ` [Announce] 'next' rewound and rebased Junio C Hamano
2008-02-21 4:16 ` What's cooking in git.git (topics) Junio C Hamano
2008-02-21 10:40 ` Johannes Schindelin
2008-02-21 16:47 ` Junio C Hamano
2008-02-22 18:47 ` Brandon Casey
2008-02-22 18:56 ` [PATCH 1/4] git-reflog: add option --rewrite to update reflog entries while expiring Brandon Casey
2008-02-22 21:08 ` Brandon Casey [this message]
[not found] ` <1203706541-21719-1-git-send-email-casey@nrlssc.navy.mil>
2008-02-22 18:57 ` [PATCH 2/4] refs.c: make close_ref() and commit_ref() non-static Brandon Casey
[not found] ` <1203706541-21719-2-git-send-email-casey@nrlssc.navy.mil>
2008-02-22 19:04 ` [PATCH 3/4] git-reflog: add option --updateref to write the last reflog sha1 into the ref Brandon Casey
[not found] ` <1203706541-21719-3-git-send-email-casey@nrlssc.navy.mil>
2008-02-22 19:04 ` [PATCH 4/4] git-stash: add new 'drop' subcommand Brandon Casey
2008-02-22 22:52 ` [PATCH] git-stash: add new 'pop' subcommand Brandon Casey
2008-02-22 22:26 ` What's cooking in git.git (topics) Junio C Hamano
2008-02-23 0:19 ` Brandon Casey
2008-02-23 0:29 ` Junio C Hamano
2008-02-23 0:51 ` Junio C Hamano
2008-02-23 2:43 ` Brandon Casey
2008-02-25 8:40 ` Junio C Hamano
2008-02-28 0:45 ` Junio C Hamano
2008-03-01 20:15 ` Junio C Hamano
2008-03-02 14:02 ` Shawn O. Pearce
2008-03-03 2:06 ` Junio C Hamano
2008-03-06 5:49 ` Junio C Hamano
2008-03-06 17:01 ` Johannes Schindelin
2008-03-08 9:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BF39EB.5040603@nrlssc.navy.mil \
--to=casey@nrlssc.navy.mil \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).