From: Johannes Sixt <j.sixt@viscovery.net>
To: Ping Yin <pkufranky@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 3/4] builtin-status: configurable submodule summary size
Date: Thu, 13 Mar 2008 15:15:02 +0100 [thread overview]
Message-ID: <47D936E6.10107@viscovery.net> (raw)
In-Reply-To: <1205416085-23431-4-git-send-email-pkufranky@gmail.com>
Ping Yin schrieb:
> + if (wt_status_submodule_summary == 0) return;
Style:
if (!wt_status_submodule_summary)
return;
> struct child_process sm_summary;
> + char summary_limit[64];
> + sprintf(summary_limit, "%d", wt_status_submodule_summary);
> const char *argv[] = {
Declaration after statement. That's not portable.
-- Hannes
next prev parent reply other threads:[~2008-03-13 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 13:48 builtin-status submodule summary Ping Yin
2008-03-13 13:48 ` [PATCH v2 1/4] git-submodule summary: --for-status option Ping Yin
2008-03-13 13:48 ` [PATCH v2 2/4] builtin-status: submodule summary support Ping Yin
2008-03-13 13:48 ` [PATCH v2 3/4] builtin-status: configurable submodule summary size Ping Yin
2008-03-13 13:48 ` [PATCH v2 4/4] buitin-status: Add tests for submodule summary Ping Yin
2008-03-13 14:21 ` Johannes Sixt
2008-03-13 18:04 ` Junio C Hamano
2008-03-13 18:14 ` Ping Yin
2008-03-13 18:09 ` Ping Yin
2008-03-13 14:15 ` Johannes Sixt [this message]
2008-03-13 14:11 ` [PATCH v2 2/4] builtin-status: submodule summary support Johannes Sixt
2008-03-13 18:01 ` Ping Yin
2008-03-14 14:30 ` builtin-status submodule summary Ping Yin
2008-03-14 16:39 ` Junio C Hamano
2008-03-14 17:45 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D936E6.10107@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).