git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, beuc@gnu.org
Subject: Re: [PATCH] git-cvsserver: handle change type T
Date: Mon, 17 Mar 2008 08:54:08 +0100	[thread overview]
Message-ID: <47DE23A0.6040100@gnu.org> (raw)
In-Reply-To: <7v4pb6gv7x.fsf@gitster.siamese.dyndns.org>


> What I am questioning is what the code should do (IOW, what would be good
> for cvs clients to see).  Should it send a symlink as a regular file, or
> simply just omit it?  If the answer is "the former", then we do not have
> to worry about it any further after applying your patch.  Otherwise we
> still have to do something _else_ after applying your patch.  I did not
> know which way we would want to proceed, and I still don't.

The reason why my patch was enough for me, is that users would just use 
the cvs bridge to stay up-to-date, not to spelunk the history (maybe to 
spelunk it with annotate, but not to look at old versions etc.).  For 
that, all I need is that current checkouts are okay.  We have to decide 
if other cvsserver use cases are common enough.

If they are, I think the optimal way to proceed could be to detect 
relative symlinks and resolve them (sending the linked file's content), 
and do "something else" (omit it, send the destination path as a regular 
file?) for absolute symlinks.

Paolo

  reply	other threads:[~2008-03-17  7:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-16 19:00 [PATCH] git-cvsserver: handle change type T Paolo Bonzini
2008-03-16 21:21 ` Junio C Hamano
2008-03-16 22:00   ` Paolo Bonzini
2008-03-16 22:28     ` Junio C Hamano
2008-03-17  7:54       ` Paolo Bonzini [this message]
2008-03-17  8:01     ` Junio C Hamano
2008-03-17 19:34       ` Martin Langhoff
2008-03-17 19:47         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47DE23A0.6040100@gnu.org \
    --to=bonzini@gnu.org \
    --cc=beuc@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).