From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Subject: Re: [PATCH] rebase [--onto O] A B: omit needless checkout
Date: Thu, 20 Mar 2008 08:41:04 +0100 [thread overview]
Message-ID: <47E21510.6020009@viscovery.net> (raw)
In-Reply-To: <7vhcf24j3e.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>
>> Junio C Hamano schrieb:
>>> This teaches "git rebase [--onto O] A B" to omit an unnecessary checkout
>>> of branch B before it goes on.
>>> ...
>> This works for a frequent use-case of mine:
>
> "Works" meaning "does not break", or "gives a great performance
> improvement that it is worth having it early in a tagged release"?
Sorry for being so terse. "Works", of course, means "works as expected",
and the "expected" part of that is that the annoyance is no longer
present, which is the unnecessary checkout.
But given how intrusive the patch is ("just to remove an unnecessary
checkout"), I'd say this is post-1.5.5 material. Also, the fact that you
had to post a fix-up is an indication that there are probably a number of
corner cases that need an extended testing period.
-- Hannes
next prev parent reply other threads:[~2008-03-20 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 19:10 optimized checkout+rebase? Ralf Wildenhues
2008-03-13 7:20 ` Johannes Sixt
2008-03-15 10:39 ` Ralf Wildenhues
2008-03-15 20:42 ` [PATCH] rebase [--onto O] A B: omit needless checkout Junio C Hamano
2008-03-15 22:21 ` Ralf Wildenhues
2008-03-16 3:56 ` Junio C Hamano
2008-03-19 12:54 ` Johannes Sixt
2008-03-19 19:19 ` Junio C Hamano
2008-03-20 7:41 ` Johannes Sixt [this message]
2008-03-20 7:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E21510.6020009@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Ralf.Wildenhues@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).