From: "Dirk Süsserott" <newsletter@dirk.my1.cc>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation: git-tag '-m' implies '-a'
Date: Tue, 25 Mar 2008 18:13:24 +0100 [thread overview]
Message-ID: <47E932B4.5060700@dirk.my1.cc> (raw)
In-Reply-To: <20080325013842.GB15607@coredump.intra.peff.net>
Jeff, thanks for the advice and the corrections, I'll act on it.
It was my first submission and I'm handicapped in the way that I'm
using Windows. So I just pasted the patch into my Thunderbird window.
The git-send-email program doesn't work properly with Windows.
Either the sendmail program isn't present (no shit sherlock ;-))
or the Net/SMTP.pm module isn't found. I'm currently writing
a wrapper to bypass that. When I manage to figure the problem,
I'll post a patch.
git-send-email for Windows doesn't accept the authorization
switches (--smtp-user, --smtp-pass) (despite the docs), so I've
either to patch it or use a wrapper that adds them.
Dirk
Jeff King schrieb:
> On Mon, Mar 24, 2008 at 01:07:15PM -0700, Junio C Hamano wrote:
>
>
>> Thanks for tidying up. It makes my life easier.
>>
>
> No problem.
>
>
>>> - at least cc Junio on patch submissions to make sure he sees it
>>> - sign off your patch (either with commit -s or format-patch -s).
>>>
>> Heh, and you did not sign it off when you forwarded? ;-)
>>
>
> Heh. Believe it or not, that actually did occur to me. However, I'm not
> really sure what it means to do that. As you have made clear in the
> past, the signoff is _not_ "this looks good to me, please apply" but
> rather "I am signing the Certificate of Origin."
>
> And while I can only assume that everything in such an obvious patch is
> kosher, it is _not_ true that:
>
> - I created or have the right to submit it under an open source
> license (DCO, part a)
> - The contribution was provided to me by somebody else who certified
> the above (DCO, part c)
>
> I'm not clear on what part (b) of the DCO means. Is it making a
> judgement that says "even though I have no license on this, it is
> clearly a derivative work of git, which is GPL'd, and therefore it is
> GPL'd"?
>
> -Peff
>
>
prev parent reply other threads:[~2008-03-25 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 14:41 [PATCH] Documentation: git-tag '-m' implies '-a' Dirk Süsserott
2008-03-24 19:43 ` Jeff King
2008-03-24 20:07 ` Junio C Hamano
2008-03-25 1:38 ` Jeff King
2008-03-25 17:13 ` Dirk Süsserott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E932B4.5060700@dirk.my1.cc \
--to=newsletter@dirk.my1.cc \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).