From: Sam Vilain <sam@vilain.net>
To: Eyvind Bernhardsen <eyvind-git@orakel.ntnu.no>
Cc: Avery Pennarun <apenwarr@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git-submodule getting submodules from the parent repository
Date: Mon, 31 Mar 2008 09:19:10 +1300 [thread overview]
Message-ID: <47EFF5BE.7030502@vilain.net> (raw)
In-Reply-To: <C38585A9-F09C-4A5B-8E72-6F3127DB2BB9@orakel.ntnu.no>
Eyvind Bernhardsen wrote:
> Well, the point of "submodule push" was to avoid having to push in
> each submodule manually; not enforcing the requirement that commits in
> submodules must be publicly available before pushing from the main
> module is a recipe for disaster, or at least annoyance. And nobody
> likes an annoying git.
ok. so, refuse to push without forcing, don't do something dumb.
> Pushing to a branch works except that I couldn't figure out what to do
> if the push doesn't succeed, ie, the branch has advanced on the remote
> end.
It's simple. You just fail and tell the user what happened, and let
them decide what to do.
> It's a reflog, not a branch, because a submodule can be changed to a
> different branch, rewound, etc between commits in the main module;
> there's no requirement that the old commit is in the new commit's
> history.
If it is a rewind there is no issue, because you don't even need to push.
But again it comes back to - let the user sort it out, don't try to be
too clever.
Sam.
next prev parent reply other threads:[~2008-03-30 20:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 22:35 git-submodule getting submodules from the parent repository Avery Pennarun
2008-03-29 23:22 ` Sam Vilain
2008-03-30 13:32 ` Eyvind Bernhardsen
2008-03-30 17:48 ` Sam Vilain
2008-03-30 19:50 ` Eyvind Bernhardsen
2008-03-30 20:19 ` Sam Vilain [this message]
2008-03-31 10:05 ` Eyvind Bernhardsen
2008-03-30 23:03 ` Avery Pennarun
2008-03-31 9:29 ` Eyvind Bernhardsen
2008-03-31 21:36 ` Avery Pennarun
2008-04-01 23:05 ` Sam Vilain
2008-04-01 23:56 ` Avery Pennarun
2008-04-02 0:35 ` Junio C Hamano
2008-04-02 2:03 ` Avery Pennarun
2008-04-02 20:06 ` Sam Vilain
2008-04-02 21:32 ` Junio C Hamano
2008-03-30 23:00 ` Avery Pennarun
2008-04-01 23:10 ` Sam Vilain
2008-03-31 6:22 ` Johannes Sixt
2008-03-31 21:24 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EFF5BE.7030502@vilain.net \
--to=sam@vilain.net \
--cc=apenwarr@gmail.com \
--cc=eyvind-git@orakel.ntnu.no \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).