git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Bryan Donlan <bdonlan@gmail.com>
Cc: Adam Roben <aroben@apple.com>, git@vger.kernel.org
Subject: Re: "make test" fails if /path/to/git.git contains spaces
Date: Tue, 01 Apr 2008 08:29:58 +0200	[thread overview]
Message-ID: <47F1D666.9060402@viscovery.net> (raw)
In-Reply-To: <3e8340490803311604v52ab9e03nd101ccadd4973760@mail.gmail.com>

Bryan Donlan schrieb:
> On Mon, Mar 31, 2008 at 5:51 PM, Adam Roben <aroben@apple.com> wrote:
>>  Do we want to support having spaces in your path? It doesn't seem hard
>>  to fix, but it does seem like the kind of problem that will come up over
>>  and over again if only a very small set of people have this configuration.
> 
> Turns out that while trying to fix the tests, I've found that
> git-rebase doesn't like a $VISUAL having spaces, so perhaps this
> should be tested more often :) Or should we just require $VISUAL have
> no spaces?
> 
> I'll send a patch once I've got everything passing.

There was an attempt in the past to make this working. Please look at this
(rather lengthy) thread, in particular, my critique on the patches that
were submitted:

http://thread.gmane.org/gmane.comp.version-control.git/60544

I really would not like to see the same issues that I took the time to
comment on to show up again.

-- Hannes

  reply	other threads:[~2008-04-01  6:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31 21:51 "make test" fails if /path/to/git.git contains spaces Adam Roben
2008-03-31 23:04 ` Bryan Donlan
2008-04-01  6:29   ` Johannes Sixt [this message]
2008-04-03  2:26     ` Bryan Donlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F1D666.9060402@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=aroben@apple.com \
    --cc=bdonlan@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).