git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Vilain <sam@vilain.net>
To: Dmitry Potapov <dpotapov@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Avery Pennarun <apenwarr@gmail.com>,
	Eric Wong <normalperson@yhbt.net>,
	git@vger.kernel.org, Avery Pennarun <apenwarr@versabanq.com>
Subject: Re: [PATCH 2/3] git-svn: Add --add-author-from option.
Date: Thu, 17 Apr 2008 10:24:03 +1200	[thread overview]
Message-ID: <48067C83.4020209@vilain.net> (raw)
In-Reply-To: <20080416192312.GF3133@dpotapov.dyndns.org>

Dmitry Potapov wrote:
> On Wed, Apr 16, 2008 at 11:36:26AM -0700, Junio C Hamano wrote:
>   
>> It makes me wonder if there is a better way.
>>
>> For example, CVS honors LOGNAME to allow you to "lie" who the author of a
>> change was, which is the behaviour inherited from RCS.  I have to wonder
>> if SVN has a similar mechanism to tell it "Excuse me, but I am just a
>> secretary recording changes for my boss."
>>     
>
> Yes, there is such a mechanism:
> ====
> Revision Property (revprop)
>
> Just as files can have properties, so can each revision in the
> repository. Some special revprops are added automatically when the
> revision is created, namely: svn:date svn:author svn:log which represent
> the commit date/time, the committer and the log message respectively.
> These properties can be edited, but they are not versioned, so any
> change is permanent and cannot be undone. 
> ====
>
> So, it is possible not only set the real author but also date/time.
> Unfortunately, there is one problem with this approach -- by default,
> these properties are disabled from modification for security reasons.
> To enable modification of these properties, the administrator is
> required to change some hooks. Personally, I have never observed any
> SVN repository where anyone was granted the right to change them. So,
> while it is possible, it is impractical.

Yes, and in fact with most shared SVN hosting services the users are 
left with no option to do this.

While there doesn't seem to be a command-line way to do this, it's 
possible that a commit "editor" making a new commit can create revision 
properties without being necessarily subject to those restrictions. 
Possible, but I guess unlikely as it would then be inconsistent.

The usual thing is to dump the extra information in the commit message. 
Some projects, like Perl, were quite systematic about this and a lot of 
useful author information is available. In fact, it was saved in the 
proposed form.

While not the main thrust of this thread, the usual convention for 
mapping svn committers to names is a project AUTHORS file. This made me 
wonder whether allowing git-svn to take its author map from the 
repository, such as from a revision property or a directory property of 
the root or project would be a good idea.

Sam

  reply	other threads:[~2008-04-16 22:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-16  1:04 [PATCH 1/3] git-svn: add documentation for --use-log-author option apenwarr
2008-04-16  1:04 ` [PATCH 2/3] git-svn: Add --add-author-from option apenwarr
2008-04-16  1:04   ` [PATCH 3/3] git-svn: add documentation for " apenwarr
2008-04-16  4:33   ` [PATCH 2/3] git-svn: Add " Junio C Hamano
2008-04-16 16:46     ` Avery Pennarun
2008-04-16 18:36       ` Junio C Hamano
2008-04-16 18:45         ` Avery Pennarun
2008-04-16 19:11         ` Richard Quirk
2008-04-16 19:23         ` Dmitry Potapov
2008-04-16 22:24           ` Sam Vilain [this message]
2008-04-16 22:34             ` Avery Pennarun
2008-04-17  4:36   ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48067C83.4020209@vilain.net \
    --to=sam@vilain.net \
    --cc=apenwarr@gmail.com \
    --cc=apenwarr@versabanq.com \
    --cc=dpotapov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).