From: Johannes Sixt <j.sixt@viscovery.net>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Peter Karlsson <peter@softwolves.pp.se>,
git@vger.kernel.org
Subject: Re: Git on Windows, CRLF issues
Date: Thu, 24 Apr 2008 08:25:56 +0200 [thread overview]
Message-ID: <481027F4.5060905@viscovery.net> (raw)
In-Reply-To: <32541b130804231302i732dbf08v88f8909f241ab99@mail.gmail.com>
Avery Pennarun schrieb:
> On 4/23/08, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> In practice, this is not sufficient. The blob filter must have an
>> opportunity to decide what it wants to do, not just blindly munge every
>> blob. The minimum is a path name, e.g. in $1:
>
> Actually, it may not have been intentional, but because of the way
> 'eval' works, the munge script will find that $path already contains
> the path of the file being munged. Works for me.
Yes, of course! So I stand corrected, and Jeff's patch makes sense.
For consistency's sake, the path should be made available in, say,
GIT_BLOB_PATH just like the commit is available in GIT_COMMIT.
-- Hannes
next prev parent reply other threads:[~2008-04-24 6:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 19:48 Git on Windows, CRLF issues Peter Karlsson
2008-04-21 20:07 ` Johannes Schindelin
2008-04-21 21:53 ` Avery Pennarun
2008-04-22 2:39 ` Jeff King
2008-04-22 16:51 ` Avery Pennarun
2008-04-23 7:11 ` Peter Karlsson
2008-04-23 8:10 ` Jeff King
2008-04-23 13:47 ` Peter Karlsson
2008-04-23 14:24 ` Johan Herland
2008-04-23 15:12 ` Johannes Sixt
2008-04-23 8:08 ` Jeff King
2008-04-23 10:13 ` Johannes Schindelin
2008-04-23 10:58 ` Jeff King
2008-04-23 10:58 ` Johannes Sixt
2008-04-23 11:04 ` Jeff King
2008-04-23 11:46 ` Johannes Sixt
2008-04-23 21:47 ` Jeff King
2008-04-23 23:01 ` Junio C Hamano
2008-04-23 23:04 ` Avery Pennarun
2008-04-24 8:11 ` Johannes Schindelin
2008-04-24 16:56 ` Avery Pennarun
2008-04-24 1:37 ` Jeff King
2008-04-23 20:02 ` Avery Pennarun
2008-04-24 6:25 ` Johannes Sixt [this message]
2008-04-22 6:41 ` Johannes Sixt
2008-04-21 21:51 ` Jakub Narebski
2008-04-22 6:52 ` Peter Karlsson
2008-04-22 9:04 ` Johannes Sixt
2008-04-22 6:31 ` Johannes Sixt
2008-04-22 8:42 ` Peter Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481027F4.5060905@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=peter@softwolves.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).