git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Mike Ralphson <mike.ralphson@gmail.com>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Makefile: update the default build options for AIX
Date: Wed, 07 May 2008 17:39:10 +0200	[thread overview]
Message-ID: <4821CD1E.80603@viscovery.net> (raw)
In-Reply-To: <e2b179460805070815u6cc627feo6137084fe7c5a635@mail.gmail.com>

Mike Ralphson schrieb:
> 2008/5/7 Brandon Casey <casey@nrlssc.navy.mil>:
>>  How about something like this?
>>
>>  diff --git a/compat/fopen.c b/compat/fopen.c
>>  index ccb9e89..70b0d4d 100644
>>  --- a/compat/fopen.c
>>  +++ b/compat/fopen.c
>>  @@ -1,5 +1,5 @@
>>  +#undef FREAD_READS_DIRECTORIES
>>   #include "../git-compat-util.h"
>>  -#undef fopen
>>   FILE *git_fopen(const char *path, const char *mode)
>>   {
>>         FILE *fp;
>>
>>
>>  -brandon
>>
> 
> Ta. I still get all the warnings with that, was that what you were
> trying to solve? The 64 bit specific tests in t5302 do still pass.

You should get one less warning (the one from compat/fopen.c), but this
time they *are* harmless. ;)

-- Hannes

  reply	other threads:[~2008-05-07 15:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07  8:35 [PATCH] Makefile: update the default build options for AIX Mike Ralphson
2008-05-07 11:57 ` Johannes Sixt
2008-05-07 12:51   ` Mike Ralphson
2008-05-07 13:05     ` Mike Ralphson
2008-05-07 13:14     ` Johannes Sixt
2008-05-07 14:20       ` Mike Ralphson
2008-05-07 14:38       ` Brandon Casey
2008-05-07 15:15         ` Mike Ralphson
2008-05-07 15:39           ` Johannes Sixt [this message]
2008-05-07 15:40           ` Brandon Casey
2008-05-07 16:04             ` Junio C Hamano
2008-05-07 16:20               ` Mike Ralphson
2008-05-07 17:36                 ` Brandon Casey
2008-05-07 17:34               ` [PATCH] compat/fopen.c: avoid clobbering the system defined fopen macro Brandon Casey
2008-05-08  7:27                 ` Mike Ralphson
2008-05-08  7:34                   ` Johannes Sixt
2008-05-08  7:59                     ` Mike Ralphson
2008-05-08 10:37                   ` H.Merijn Brand
2008-05-16 10:19   ` [PATCH] Makefile: update the default build options for AIX Mike Ralphson
2008-05-16 13:37     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4821CD1E.80603@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mike.ralphson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).