From: "epankala@cc.hut.fi" <epankala@cc.hut.fi>
To: git@vger.kernel.org
Subject: GIT max file size.
Date: Thu, 08 May 2008 19:33:12 +0300 [thread overview]
Message-ID: <48232B48.9010900@cc.hut.fi> (raw)
Hello.
I received "fatal: Out of memory, malloc failed" error when I tried to
check in file of ~2.5G
It can be argued that binary file of that size (or binary file
altogether) has no place in version control anyways, but still I pursued
it a bit more.
In #git@freenode channel I received some hints and in the end I started
running
"git-hash-object -w images/filesystem_ext2.img.bz2"
It would seem that sha1_file.c:write_sha1_file() has defined size
variable as integer.
This wraps around in "size = 8 + deflateBound(&stream, len+hdrlen);" and
gives big number for mmap()
mmap(NULL, 18446744071976239104, PROT_READ|PROT_WRITE,
MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = -1 ENOMEM (Cannot allocate memory)
size is used in "stream.avail_out = size;" and zstream.avail_out seems
to be unsigned int
"uInt avail_out; /* remaining free space at next_out */"
If size would be changed to unsigned would the max filesize be increased
to ~4G or would it blow up elsewhere?
Is git going to support >2G files or is having "everything that is
needed to complete build process from beginning to bitter end" in
version control something that git is not meant for?
If latter is true then this would be pretty much pointless change. If
former then changing 'size' to integer won't be enough anyways...
Best Regards
Janne Pänkälä
--
Janne Pänkälä
next reply other threads:[~2008-05-08 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 16:33 epankala [this message]
2008-05-08 18:46 ` GIT max file size Alex Riesen
2008-05-08 20:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48232B48.9010900@cc.hut.fi \
--to=epankala@cc.hut.fi \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).