git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <junio@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 4/4] filter-branch: fix variable export logic
Date: Wed, 14 May 2008 11:33:50 +0200	[thread overview]
Message-ID: <482AB1FE.6030009@gnu.org> (raw)
In-Reply-To: <20080514045717.GA16592@sigill.intra.peff.net>


>   if test -n "$ORIG_GIT_DIR"
>   then
>     ...
>   fi
> 
> would be even clearer, though I'm not sure if "-n" has any portability
> concerns.

It has not.  Some autoconf scripts do

   if test "x$ORIG_GIT_DIR" != x; then
     ...
   fi

(and similarly for -z) but that's being phased out.

Paolo

  reply	other threads:[~2008-05-14  9:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13  8:43 [PATCH 0/4] freebsd portability fixes Jeff King
2008-05-13  8:44 ` [PATCH 1/4] fix bsd shell negation Jeff King
2008-05-14  2:27   ` Junio C Hamano
2008-05-14  4:01     ` Jeff King
2008-05-13  8:45 ` [PATCH 2/4] t5000: tar portability fix Jeff King
2008-05-13  8:45 ` [PATCH 3/4] clone: bsd shell " Jeff King
2008-05-13  8:46 ` [PATCH 4/4] filter-branch: fix variable export logic Jeff King
2008-05-14  4:18   ` Junio C Hamano
2008-05-14  4:57     ` Jeff King
2008-05-14  9:33       ` Paolo Bonzini [this message]
2008-05-13  9:04 ` [PATCH 0/4] freebsd portability fixes Jeff King
2008-05-13 20:39   ` Alex Riesen
2008-05-13 20:44     ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482AB1FE.6030009@gnu.org \
    --to=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).