From: David Reiss <dreiss@facebook.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Add support for GIT_CEILING_DIRS
Date: Thu, 15 May 2008 00:11:52 -0700 [thread overview]
Message-ID: <482BE238.5020309@facebook.com> (raw)
In-Reply-To: <482BE0EB.6040306@viscovery.net>
> If you make it so that the default value of ceil_offset is 0 (i.e. in the
> absence of any GIT_CEILING_DIRS),
This is what the new version of the patch does.
> and at this place you did
>
> } while (offset > ceil_offset && cwd[--offset] != '/');
>
> you wouldn't have to bend backwards with this off-by-one magic, would you?
It seems like that would cause it to continue on with the outer loop, rather
than aborting (which is what the current version does) when you hit the ceiling.
Or maybe I'm misunderstanding something.
--David
next prev parent reply other threads:[~2008-05-15 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 1:35 [PATCH v2] Add support for GIT_CEILING_DIRS David Reiss
2008-05-15 7:06 ` Johannes Sixt
2008-05-15 7:11 ` David Reiss [this message]
2008-05-15 8:38 ` Johannes Sixt
2008-05-15 9:06 ` Johannes Schindelin
2008-05-15 16:26 ` David Reiss
2008-05-15 17:45 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482BE238.5020309@facebook.com \
--to=dreiss@facebook.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).