git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Cc: David Reiss <dreiss@facebook.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] Add support for GIT_CEILING_DIRS
Date: Fri, 16 May 2008 09:03:20 +0200	[thread overview]
Message-ID: <482D31B8.8000707@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0805152131390.30431@racer>

Johannes Schindelin schrieb:
> On Thu, 15 May 2008, Junio C Hamano wrote:
> 
>> David Reiss <dreiss@facebook.com> writes:
>> How well would this colon separated list work with msys folks?
> 
> Not well at all.  At least for the moment, I think setting this variable 
> would fail (since it would be rewritten into a Windows-PATH-style string).  
> Though honestly, I have no idea what getcwd() does on MinGW.

We would have to use ';' instead of ':' in longest_prefix(). Then it will
work automatically. Except that it does not ignore case in path names and
drive letters. Hence, the user must set this environment variable to the
precise path name(s).

> Steffen is working on that rewriting stuff, so maybe it will be a 
> non-issue, eventually.

This will not matter. When we change the code to use is_path_separator()
instead of hard-coded c == ':', then it will work automatically. We do
that already for GIT_ALTERNATE_OBJECT_DIRECTORIES.

-- Hannes

  reply	other threads:[~2008-05-16  7:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15 18:49 [PATCH v3] Add support for GIT_CEILING_DIRS David Reiss
2008-05-15 19:03 ` Johannes Schindelin
2008-05-15 19:40   ` David Reiss
2008-05-15 20:27   ` [PATCH] Add support for GIT_CEILING_DIRECTORIES Johannes Schindelin
2008-05-15 21:09     ` David Reiss
2008-05-15 22:29       ` Johannes Schindelin
2008-05-15 22:45         ` David Reiss
2008-05-15 23:27           ` [SQUASHED PATCH] " Johannes Schindelin
2008-05-16  6:54             ` Johannes Sixt
2008-05-16 10:20               ` Johannes Schindelin
2008-05-16 10:50                 ` Johannes Sixt
2008-05-16 17:43                   ` David Reiss
2008-05-17  0:19                     ` Johannes Schindelin
2008-05-17  0:20                       ` [2nd SQUASHED " Johannes Schindelin
2008-05-19  7:55                       ` [SQUASHED " Johannes Sixt
2008-05-19 10:49                         ` Johannes Schindelin
2008-05-15 19:46 ` [PATCH v3] Add support for GIT_CEILING_DIRS Junio C Hamano
2008-05-15 20:34   ` Johannes Schindelin
2008-05-16  7:03     ` Johannes Sixt [this message]
2008-05-16 10:21       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482D31B8.8000707@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dreiss@facebook.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).