From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: gitster@pobox.com, David Reiss <dreiss@facebook.com>,
git@vger.kernel.org
Subject: Re: [SQUASHED PATCH] Add support for GIT_CEILING_DIRECTORIES
Date: Fri, 16 May 2008 12:50:04 +0200 [thread overview]
Message-ID: <482D66DC.30602@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0805161118160.30431@racer>
Johannes Schindelin schrieb:
> Hi,
>
> On Fri, 16 May 2008, Johannes Sixt wrote:
>
>> Johannes Schindelin schrieb:
>>> +'GIT_CEILING_DIRECTORIES'::
>>> + If set (to a colon delimited list of absolute directories), Git
>>> + will refuse to look for the .git/ directory further when hitting
>>> + one of those directories (otherwise it would traverse the parent
>>> + directories until hitting the root directory).
>> Hmm.
>>
>> Looking at the current implementation, this should be written as:
>>
>> If set to a colon delimited list of absolute directories,
>> and the current directory is in or below one of them, then
>> these are the top-most directories in which Git will look for
>> a .git/ directory (otherwise it would traverse the parent
>> directories until hitting the root directory).
>
> According to the test case
>
> GIT_CEILING_DIRECTORIES="$CWD/X:$CWD/subdir" &&
> export GIT_CEILING_DIRECTORIES &&
> (cd subdir && test_must_fail git rev-parse --git-dir)
>
> this is not the case. If you have something like /bla/subdir and you are
> in /bla/subdir, it will not look for .git/.
No, the test just shows that it does not *find* a subdir/.git/, but it
does not show that it doesn't even *look* for it.
Let's first clarify the semantics of GIT_CEILING_DIRECTORIES before we
start fixing something: Can a directory that is named in
GIT_CEILING_DIRECTORIES be a git repository or not?
David's original motivation was that it cannot; in your implementation it can.
-- Hannes
next prev parent reply other threads:[~2008-05-16 10:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 18:49 [PATCH v3] Add support for GIT_CEILING_DIRS David Reiss
2008-05-15 19:03 ` Johannes Schindelin
2008-05-15 19:40 ` David Reiss
2008-05-15 20:27 ` [PATCH] Add support for GIT_CEILING_DIRECTORIES Johannes Schindelin
2008-05-15 21:09 ` David Reiss
2008-05-15 22:29 ` Johannes Schindelin
2008-05-15 22:45 ` David Reiss
2008-05-15 23:27 ` [SQUASHED PATCH] " Johannes Schindelin
2008-05-16 6:54 ` Johannes Sixt
2008-05-16 10:20 ` Johannes Schindelin
2008-05-16 10:50 ` Johannes Sixt [this message]
2008-05-16 17:43 ` David Reiss
2008-05-17 0:19 ` Johannes Schindelin
2008-05-17 0:20 ` [2nd SQUASHED " Johannes Schindelin
2008-05-19 7:55 ` [SQUASHED " Johannes Sixt
2008-05-19 10:49 ` Johannes Schindelin
2008-05-15 19:46 ` [PATCH v3] Add support for GIT_CEILING_DIRS Junio C Hamano
2008-05-15 20:34 ` Johannes Schindelin
2008-05-16 7:03 ` Johannes Sixt
2008-05-16 10:21 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482D66DC.30602@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=dreiss@facebook.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).