git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Mike Ralphson <mike.ralphson@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: update the default build options for AIX
Date: Fri, 16 May 2008 15:37:11 +0200	[thread overview]
Message-ID: <482D8E07.3050300@viscovery.net> (raw)
In-Reply-To: <e2b179460805160319n420c309eg9b9bbb1e3adb299@mail.gmail.com>

Mike Ralphson schrieb:
> 2008/5/7 Johannes Sixt <j.sixt@viscovery.net>:
>> Mike Ralphson schrieb:
>>> NO_MKDTEMP is required to build, FREAD_READS_DIRECTORIES and the definition
>>> of _LARGE_FILES fix test suite failures and INTERNAL_QSORT is required for
>>> adequate performance.
>> I'm trying this patch on AIX 4.3.3 (sigh!) with gcc3...
> 
> Now the interaction between FREAD_READS_DIRECTORIES and _LARGE_FILES
> has been sorted out, and the
> wt-status.h warning fix is also in, did you manage to finish testing
> this? The INTERNAL_QSORT gave me a 2 orders of magnitude speed up on
> git status / commit etc.
> 
> I should have mentioned that I build with SHELL_PATH = /bin/bash and
> ensure that /usr/linux/bin (or /opt/freeware/bin) from the AIX toolbox
> is prepended to the PATH to run the test-suite. I didn't want to fold
> these into the patch as the paths are somewhat environment specific.

I compiled git on AIX 4.3.3.  Even though the testsuite does not pass (due
to a too old perl, non-working libiconv, and a sed that does not print the
last line if there's no LF at the end), there's no failure that I would
attribute to your changes. Therefore, I'd say:

Tested-by: Johannes Sixt <johannes.sixt@telecom.at>

-- Hannes

      reply	other threads:[~2008-05-16 13:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07  8:35 [PATCH] Makefile: update the default build options for AIX Mike Ralphson
2008-05-07 11:57 ` Johannes Sixt
2008-05-07 12:51   ` Mike Ralphson
2008-05-07 13:05     ` Mike Ralphson
2008-05-07 13:14     ` Johannes Sixt
2008-05-07 14:20       ` Mike Ralphson
2008-05-07 14:38       ` Brandon Casey
2008-05-07 15:15         ` Mike Ralphson
2008-05-07 15:39           ` Johannes Sixt
2008-05-07 15:40           ` Brandon Casey
2008-05-07 16:04             ` Junio C Hamano
2008-05-07 16:20               ` Mike Ralphson
2008-05-07 17:36                 ` Brandon Casey
2008-05-07 17:34               ` [PATCH] compat/fopen.c: avoid clobbering the system defined fopen macro Brandon Casey
2008-05-08  7:27                 ` Mike Ralphson
2008-05-08  7:34                   ` Johannes Sixt
2008-05-08  7:59                     ` Mike Ralphson
2008-05-08 10:37                   ` H.Merijn Brand
2008-05-16 10:19   ` [PATCH] Makefile: update the default build options for AIX Mike Ralphson
2008-05-16 13:37     ` Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482D8E07.3050300@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mike.ralphson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).