From: Tommy Thorn <tommy-git@thorn.ws>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Avery Pennarun <apenwarr@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
Date: Fri, 16 May 2008 17:06:13 -0700 [thread overview]
Message-ID: <482E2175.8030904@thorn.ws> (raw)
In-Reply-To: <alpine.DEB.1.00.0805170058160.30431@racer>
Johannes Schindelin wrote:
> +/*
> + * This is an ugly hack to avoid fgetc(), which is slow, as it is locking.
> + * The argument "in" must be the same for all calls to this function!
> + */
> +static int fast_fgetc(FILE *in)
> +{
>
Looks great to me, but shouldn't you add an "inline" for this one? Also,
maybe a double the buffer size.
Tommy
next prev parent reply other threads:[~2008-05-17 0:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 7:27 git bug: rebase fatal failure Tommy Thorn
2008-05-16 10:41 ` Johannes Schindelin
2008-05-16 11:01 ` Johannes Schindelin
2008-05-16 13:03 ` [PATCH] mailsplit and mailinfo: gracefully handle NUL characters Johannes Schindelin
2008-05-16 14:03 ` Avery Pennarun
2008-05-16 14:05 ` David Kastrup
2008-05-16 14:32 ` Johannes Schindelin
2008-05-16 14:56 ` Avery Pennarun
2008-05-16 23:59 ` Johannes Schindelin
2008-05-17 0:06 ` Tommy Thorn [this message]
2008-05-17 0:26 ` Johannes Schindelin
2008-05-17 10:07 ` Stephen R. van den Berg
2008-05-17 10:18 ` Johannes Schindelin
[not found] ` <200805161539.29259.brian.foster@innova-card.com>
2008-05-16 14:07 ` Brian Foster
2008-05-16 14:14 ` David Kastrup
2008-05-16 14:29 ` Johannes Schindelin
2008-05-16 14:33 ` David Kastrup
2008-05-21 18:08 ` Junio C Hamano
2008-05-22 10:38 ` Johannes Schindelin
2008-05-22 17:44 ` Junio C Hamano
2008-05-23 11:21 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482E2175.8030904@thorn.ws \
--to=tommy-git@thorn.ws \
--cc=Johannes.Schindelin@gmx.de \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).