From: Mark Levedahl <mdl123@verizon.net>
To: Jeff King <peff@peff.net>
Cc: Alex Riesen <raa.lkml@gmail.com>,
git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: t3701 fails if core.filemode disabled
Date: Sun, 18 May 2008 20:17:30 -0400 [thread overview]
Message-ID: <4830C71A.60308@verizon.net> (raw)
In-Reply-To: <20080518190839.GC15506@sigill.intra.peff.net>
Jeff King wrote:
> On Sun, May 18, 2008 at 05:23:37PM +0200, Alex Riesen wrote:
>
>> This is on Cygwin, yes. I have the core.filemode disabled in
>> ~/.gitconfig. How about stopping the test before the failing portion
>> (only the last two fail, below)?
>
> What's in your ~/.gitconfig shouldn't have any effect (the test scripts
> take care to avoid looking at anything outside of your git directory).
> But presumably this test is broken on Cygwin, anyway?
>
On Cygwin, support for correctly interpreting the execute bit is governed by the
operating system (WindowsNT/XP vs Windows9x), the file system (NTFS vs FAT), and
the (NO)NTEA and (NO)NTSEC options via the CYGWIN environment variable. So,
there is no simple answer... By default on WindowsNT/XP and running on NTFS,
execute modes are supported and the git testsuite currently works.
Some other configurations will not support core.filemode=true, but Cygwin's
stated goal is to emulate Linux and it does so by default using current common
configurations. Thus, disabling the tests unconditionally on Cygwin would be wrong.
Perhaps the better path is to skip the tests if "$(uname -o)" = "Cygwin" and
core.filemode=false, but enable them otherwise, allowing users who know their
configuration will not support the execute bit to avoid the test failure.
Mark
next prev parent reply other threads:[~2008-05-19 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 15:23 t3701 fails if core.filemode disabled Alex Riesen
2008-05-18 15:35 ` Johannes Schindelin
2008-05-18 17:04 ` Alex Riesen
2008-05-18 19:08 ` Jeff King
2008-05-18 20:01 ` Alex Riesen
2008-05-19 20:23 ` Alex Riesen
2008-05-19 20:55 ` Jeff King
2008-05-20 21:59 ` [PATCH] Fix t3701 " Alex Riesen
2008-05-21 14:36 ` Jeff King
2008-05-22 13:20 ` Alex Riesen
2008-05-22 17:49 ` Junio C Hamano
2008-05-22 17:55 ` Jeff King
2008-05-22 21:22 ` Alex Riesen
2008-05-19 0:17 ` Mark Levedahl [this message]
2008-05-19 6:01 ` t3701 fails " Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4830C71A.60308@verizon.net \
--to=mdl123@verizon.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).