From: David Reiss <dreiss@facebook.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] Implement normalize_absolute_path
Date: Tue, 20 May 2008 09:44:26 -0700 [thread overview]
Message-ID: <4832FFEA.7020905@facebook.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0805201321300.30431@racer>
> I wonder why my advice to look at setup.c (I think I did not mention the
> function name "sanitary_path_copy()" in particular, because I figured you
> would spot it right away) went unheeded.
I wonder why my comment in the patch went unheeded:
> The closest thing I could find to this in the existing code base was
> sanitary_path_copy, but it does not remove trailing slashes.
Honestly, I found it quite daunting to try to track down all of the
indirect callers of sanitary_path_copy and ensure that they would
continue to work if I changed the behavior of a function that does not
document what it is supposed to do. Frankly, it would be easier for me
to just keep rebasing my patches and apply them to my local builds.
--David
next prev parent reply other threads:[~2008-05-20 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 6:48 [PATCH 1/4] Implement normalize_absolute_path David Reiss
2008-05-20 12:22 ` Johannes Schindelin
2008-05-20 16:44 ` David Reiss [this message]
2008-05-20 22:24 ` Alex Riesen
2008-05-21 8:34 ` David Reiss
2008-05-22 12:48 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4832FFEA.7020905@facebook.com \
--to=dreiss@facebook.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).