From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Harald Nordgren" <haraldnordgren@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
GGG <gitgitgadget@gmail.com>
Subject: Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone
Date: Mon, 02 Nov 2026 12:01:51 +0100 [thread overview]
Message-ID: <4836126b-e630-45cd-8757-861133ec233c@app.fastmail.com> (raw)
In-Reply-To: <CAHwyqnVzsvsGXzVj4P=rXJJTvfeQt0D39Aj7R1PTyQVkJbm4DA@mail.gmail.com>
On Mon, Nov 2, 2026, at 11:06, Harald Nordgren wrote:
> On Mon, Nov 2, 2026 at 10:21 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>> > From: Harald Nordgren <haraldnordgren@gmail.com>
>> >
>> > Asking for a commit's ancestor with <rev>~N in a shallow clone that
>> > does not have N commits of history locally fails with a bare "is not
>> > a commit" error, with no indication that the repository being shallow
>> > is the reason, or what to do about it.
>> >[snip]
>>
>> We unfortunately haven't seen many folks interested in this change.
>> Is anybody interested in reviewing the patch to give it a push?
>>
>> Unless we see some volunteers to give it a review in a few weeks, I
>> will discard the topic out of my tree, as 'seen' has been crowded
>> with topics that have been collecting dust without getting many
>> reviews.
>
> Is it possible that maybe the review process needs to change if too
> many things are getting stuck?
The regular reviewers have been talking about review work being scarce
compared to contributions (contributor work) for at least several years
now. How can this be changed if there simply aren’t enough people to
review everything? And why does it *need* to be changed? The only
contributions that I know of that git(1) *needs* is full support for
the hash transition before Git 3.0.
> Rather than discarding acceptable work.
My work which has been stuck is also acceptable to me. ;) But my
opinions are beside the point wrt. an independent review.
next prev parent reply other threads:[~2026-11-02 11:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 9:53 [PATCH] object-name: explain why <ref>~N fails in a shallow clone Harald Nordgren via GitGitGadget
2026-09-20 21:59 ` D. Ben Knoble
2026-09-21 16:50 ` Junio C Hamano
2026-09-21 22:17 ` Harald Nordgren
2026-09-21 23:00 ` Junio C Hamano
2026-09-22 13:38 ` [PATCH v2] shallow: advise when a walk stops at a shallow boundary Harald Nordgren via GitGitGadget
2026-09-22 21:20 ` Junio C Hamano
2026-09-23 18:55 ` [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone Harald Nordgren via GitGitGadget
2026-11-02 9:21 ` Junio C Hamano
2026-11-02 10:06 ` Harald Nordgren
2026-11-02 11:01 ` Kristoffer Haugsbakk [this message]
2026-11-02 11:07 ` Harald Nordgren
2026-11-02 12:24 ` Patrick Steinhardt
2026-11-02 12:44 ` Kristoffer Haugsbakk
2026-11-02 14:07 ` Harald Nordgren
2026-11-02 14:31 ` Patrick Steinhardt
2026-11-02 14:48 ` Harald Nordgren
2026-11-02 14:36 ` Phillip Wood
2026-11-02 14:52 ` Harald Nordgren
2026-11-02 18:55 ` Junio C Hamano
2026-11-02 18:40 ` Junio C Hamano
2026-11-02 12:34 ` Kristoffer Haugsbakk
2026-11-02 14:10 ` Harald Nordgren
2026-11-02 14:33 ` Patrick Steinhardt
2026-11-02 18:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4836126b-e630-45cd-8757-861133ec233c@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox