git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Levedahl <mlevedahl@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk - restore operation of git-reset on Cygwin
Date: Fri, 23 May 2008 18:26:51 -0400	[thread overview]
Message-ID: <483744AB.8070509@gmail.com> (raw)
In-Reply-To: <18486.15879.551874.408651@cargo.ozlabs.ibm.com>

Paul Mackerras wrote:
> Mark Levedahl writes:
>
>   
>> Commit 6df7403a98737 modified the call to git-reset to invoke git
>> directly rather than using "sh -c", but is redirecting stderr to stdout.
>> This does not work on Cygwin, probably because the Tcl/Tk package is
>> a windows program rather than Cygwin. The result is always an error
>> message proclaiming 'can not find channel named "1"'. This restores
>> invocation through sh -c.
>>     
>
> Are you using Tk 8.4 or 8.5?  The man pages for 8.5 imply that the
> 2>@1 form should work for all platforms, but maybe that wasn't true in
> 8.4.  If that's the case it's worth mentioning in the patch
> description.
>
> Paul.
>   
Cygwin's Tcl/Tk is essentially frozen at 8.4.1. However, I really 
believe the problem is that the Tcl/Tk is not a full Cygwin application: 
it is mostly Windows, with only a few pieces converted to Posix through 
the cygwin.dll, so many things don't quite work correctly. For instance, 
the current gitk works fine under a pure Cygwin build of Tcl/Tk (8.4.13) 
I have locally. So, I believe the commit message I wrote is correct.

Mark

  reply	other threads:[~2008-05-23 22:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23  3:00 [PATCH] gitk - restore operation of git-reset on Cygwin Mark Levedahl
2008-05-23  3:46 ` Paul Mackerras
2008-05-23 22:26   ` Mark Levedahl [this message]
2008-05-23 23:13     ` Mark Levedahl
2008-05-23 23:17       ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483744AB.8070509@gmail.com \
    --to=mlevedahl@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).