From: Lea Wiemann <lewiemann@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: only display "next" links in logs if there is a next page
Date: Wed, 28 May 2008 02:10:47 +0200 [thread overview]
Message-ID: <483CA307.8040900@gmail.com> (raw)
In-Reply-To: <7v1w3nz43f.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> I do not trust people who rely on "tests" to catch counting errors
Oh, I wasn't trying to say that I didn't "brain-check" my code for
correctness -- I just think it's a good idea to actually test it in
addition to that. :)
Anyways, thanks for reviewing and confirming it!
> I wonder if it is easier to read to use the more modern @array notation
> than historic $#array notation (it looks very Perl 4 to me), but that is a
> separate issue. gitweb is littered with such anachronism ;-)
Yup, I was trying to be consistent there.
-- Lea
next prev parent reply other threads:[~2008-05-28 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 22:31 [PATCH] gitweb: only display "next" links in logs if there is a next page Lea Wiemann
2008-05-27 23:08 ` Junio C Hamano
2008-05-27 23:23 ` Lea Wiemann
2008-05-27 23:25 ` Lea Wiemann
2008-05-27 23:30 ` Lea Wiemann
2008-05-28 0:04 ` Junio C Hamano
2008-05-28 0:10 ` Lea Wiemann [this message]
2008-05-28 9:01 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483CA307.8040900@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).