git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Marius Storm-Olsen <marius@trolltech.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 6/5] NUL hack to create_file()
Date: Thu, 29 May 2008 09:23:42 +0200	[thread overview]
Message-ID: <483E59FE.80707@viscovery.net> (raw)
In-Reply-To: <483E55C1.1000900@trolltech.com>

Marius Storm-Olsen schrieb:
> Johannes Sixt said the following on 29.05.2008 08:33:
>> Junio C Hamano schrieb:
>>> This is not meant for application to the mainline.  It allows your
>>> git to
>>> refuse to create a blob whose name is "nul".
>>
>> It's not just about "nul"; these won't work either: "aux", "prn", "con",
>> "com\d+", "lpt\d+", neither do "$one_of_these.$some_extension". And
>> all of
>> that regardless of the case!
>>
>> See http://msdn.microsoft.com/en-us/library/aa365247(VS.85).aspx
>>
>> Definitely, we don't ever want to have such special-casing somewhere
>> in git.
> 
> They _can_ be used by using the UNC notation:
>     \\?\<drive letter>:\<path>\nul
> Do you think we should special-case that, or simply fail?

Rhetoric question: What's so special about those files?

"foo/nul" is a file you don't have permissions to write to. Period. We
should fail the same way as if you had 'chmod a-w foo/nul foo', or as if
there's a bad sector on the disk. Junio's patch series is the way to go
(without 6/5, of course).

-- Hannes

  reply	other threads:[~2008-05-29  7:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29  0:17 [PATCH 0/5] "best effort" checkout Junio C Hamano
2008-05-29  0:17 ` [PATCH 1/5] "git checkout -- paths..." should error out when paths cannot be written Junio C Hamano
2008-05-29  0:17   ` [PATCH 2/5] checkout: make reset_clean_to_new() not die by itself Junio C Hamano
2008-05-29  0:17     ` [PATCH 3/5] checkout: consolidate reset_{to_new,clean_to_new|() Junio C Hamano
2008-05-29  0:17       ` [PATCH 4/5] unpack_trees(): allow callers to differentiate worktree errors from merge errors Junio C Hamano
2008-05-29  0:17         ` [PATCH 5/5] checkout: "best effort" checkout Junio C Hamano
2008-05-29  0:17           ` [PATCH 6/5] NUL hack to create_file() Junio C Hamano
2008-05-29  6:33             ` Johannes Sixt
2008-05-29  7:05               ` Marius Storm-Olsen
2008-05-29  7:23                 ` Johannes Sixt [this message]
2008-05-29 17:19                 ` Daniel Barkalow
2008-05-29 17:51                   ` Brian Dessent
2008-05-29 18:35                     ` Daniel Barkalow
2008-05-29 12:39               ` Johannes Schindelin
2008-05-29 15:55             ` Daniel Barkalow
2008-05-29 18:26               ` Junio C Hamano
2008-05-29 17:44             ` Alex Riesen
2008-05-29 23:24 ` [PATCH 0/5] "best effort" checkout Mark Levedahl
2008-05-30  0:33   ` Junio C Hamano
2008-05-30  1:09     ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483E59FE.80707@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=marius@trolltech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).