From: Lea Wiemann <lewiemann@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: git-name-rev --undefined / --always
Date: Fri, 06 Jun 2008 01:49:19 +0200 [thread overview]
Message-ID: <48487B7F.5000909@gmail.com> (raw)
The name-rev command has an option --undefined (which is not documented
in git-name-rev.txt) that doesn't do anything. If you look at
builtin-name-rev.c, allow_undefined never gets set to anything but 1, I
think. In that case --undefined could be made a dummy option for
compatibility and the allow_undefined code could be ripped out.
In the same file, there's also an "else if (always)" clause that, if
allow_undefined is indeed always true, never gets run. "git-name-ref
--tags --always master" still prints "undefined" despite the --always
option. (--always is undocumented as well.)
Perhaps someone more knowledgeable should take a look at this (and maybe
write up a test case or two), I don't feel confident submitting patches
to this file.
-- Lea
reply other threads:[~2008-06-05 23:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48487B7F.5000909@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).