* git-name-rev --undefined / --always
@ 2008-06-05 23:49 Lea Wiemann
0 siblings, 0 replies; only message in thread
From: Lea Wiemann @ 2008-06-05 23:49 UTC (permalink / raw)
To: Git Mailing List
The name-rev command has an option --undefined (which is not documented
in git-name-rev.txt) that doesn't do anything. If you look at
builtin-name-rev.c, allow_undefined never gets set to anything but 1, I
think. In that case --undefined could be made a dummy option for
compatibility and the allow_undefined code could be ripped out.
In the same file, there's also an "else if (always)" clause that, if
allow_undefined is indeed always true, never gets run. "git-name-ref
--tags --always master" still prints "undefined" despite the --always
option. (--always is undocumented as well.)
Perhaps someone more knowledgeable should take a look at this (and maybe
write up a test case or two), I don't feel confident submitting patches
to this file.
-- Lea
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-05 23:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-05 23:49 git-name-rev --undefined / --always Lea Wiemann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).