From: Marek Zawirski <marek.zawirski@gmail.com>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: spearce@spearce.org, git@vger.kernel.org
Subject: Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter
Date: Sat, 07 Jun 2008 02:06:45 +0200 [thread overview]
Message-ID: <4849D115.5030602@gmail.com> (raw)
In-Reply-To: <200806061524.04140.robin.rosenberg@dewire.com>
On Fri, Jun 6, 2008 at 3:24 PM, Robin Rosenberg
<robin.rosenberg@dewire.com> wrote:
> A well defined set of enhancements with only minor nitpicks (in separate mails)
Nice to hear. I'll send v2 of these 2 patches (04 and 09) in a moment.
With a slightly less place for nitpicks, I hope.
> I'm somewhat reluctant to reformatting patches though.
Well, so should I remove these reformatting patches from series? (oouch!)
Actually, when I ran into formatting problem, Shawn suggested that I may
format PackFile as he was also touching this file - I much appreciated
this idea. PackIndex* formatting is however my own invention.
So you assume that Eclipse 3.4 will just force us to submit new patches
with specified formatting, but keep old lines formatting untouched, am I
right?
Isn't it somewhat annoying that formatting is inconsistent through
project (especially line width in some places)? And that I almost have
to block formatting shortcut to stop my pre-save/pre-commit habit?;)
Thanks,
--
Marek Zawirski / zawir
marek.zawirski@gmail.com
next prev parent reply other threads:[~2008-06-07 0:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 21:24 [JGIT PATCH 00/12] Extensions in core needed by PackWriter Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 01/12] Format PackFile class Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 02/12] Format PackIndex class Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 03/12] Format PackIndexV1 class Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 04/12] Add getType() method to RevObject hierarchy Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 05/12] Replace instanceof in WalkFetchConnection with getType() Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 06/12] Move PackFile.SIGNATURE to Constants.PACK_SIGNATURE Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 07/12] Add overload of fromRaw() in MutableObjectId accepting int[] Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 08/12] Copying constructor of MutableObjectId Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 09/12] Add getSize() method to ObjectIdSubclassMap Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 10/12] Add getObjectCount() method to PackFile Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 11/12] Entries iterator in PackIndex and indirectly PackFile Marek Zawirski
2008-06-02 21:24 ` [JGIT PATCH 12/12] Add PackIndex specific tests, currently only iterators tests Marek Zawirski
2008-06-06 13:24 ` [JGIT PATCH 09/12] Add getSize() method to ObjectIdSubclassMap Robin Rosenberg
2008-06-07 0:10 ` [JGIT PATCH v2 09/12] Add size() " Marek Zawirski
2008-06-06 13:24 ` [JGIT PATCH 04/12] Add getType() method to RevObject hierarchy Robin Rosenberg
2008-06-07 0:10 ` [JGIT PATCH v2 " Marek Zawirski
2008-06-02 22:15 ` [JGIT PATCH 00/12] Extensions in core needed by PackWriter Johannes Schindelin
2008-06-02 22:58 ` Marek Zawirski
2008-06-02 23:43 ` Johannes Schindelin
2008-06-06 13:24 ` Robin Rosenberg
2008-06-07 0:06 ` Marek Zawirski [this message]
2008-06-07 7:16 ` Shawn O. Pearce
2008-06-10 21:09 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4849D115.5030602@gmail.com \
--to=marek.zawirski@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).