From: Paolo Bonzini <bonzini@gnu.org>
To: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] provide a new "theirs" strategy, useful for rebase --onto
Date: Sun, 08 Jun 2008 04:54:13 +0200 [thread overview]
Message-ID: <484B49D5.8080708@gnu.org> (raw)
In-Reply-To: <7vfxrqrwjm.fsf@gitster.siamese.dyndns.org>
> Because original E' was an amend of E, its log message explained
> everything E did and more. You cannot leave that same commit message in
> E''. What you did in E was already explained in the history, so now you
> would want to talk about the incremental change on top of it when you
> desribe E''. For that, replaying of E' must stop to allow you to fix up
> the log message.
Yes, I had suggested in the original thread to follow up with a "git
rebase -i" to fix the commit message, because "git-rebase--interactive
--help" did not show a -s option. However, I found out that it does
support it, so it is probably better to use "git rebase -i -s theirs
--onto ..." directly.
> Yes, you may want an easy way to say "the result should have the same tree
> as E'" while replaying of E' on top of E _when_ you have to resolve the
> conflict. But that is a separate issue ("git checkout $other_head --
> $conflicted_paths", or somesuch). Using this in rebase is a horrible
> example inviting misuse and a broken history, I think.
You mean that I should a) drop the example from git-rebase.1, b) reword
it to clarify it, c) drop the patch completely?
Paolo
next prev parent reply other threads:[~2008-06-08 2:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 10:59 [PATCH] provide a new "theirs" strategy, useful for rebase --onto Paolo Bonzini
2008-06-06 11:27 ` Peter Karlsson
2008-06-06 11:28 ` Paolo Bonzini
2008-06-06 14:14 ` Miklos Vajna
2008-06-06 23:08 ` Junio C Hamano
2008-06-08 2:54 ` Paolo Bonzini [this message]
2008-06-08 8:16 ` Junio C Hamano
2008-06-08 13:38 ` Paolo Bonzini
2008-06-08 20:59 ` Junio C Hamano
2008-06-08 23:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484B49D5.8080708@gnu.org \
--to=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).