From: Lea Wiemann <lewiemann@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing
Date: Mon, 09 Jun 2008 15:27:22 +0200 [thread overview]
Message-ID: <484D2FBA.1010606@gmail.com> (raw)
In-Reply-To: <m3lk1ex3s6.fsf@localhost.localdomain>
Jakub Narebski wrote:
> I think the (usual) solution is to add --ignore-missing and
> --no-ignore-missing (or --noignore-missing), add configuration
> option 'catfile.ignoreMissing', make ignore-missing default and
> deprecate it with some transition time...
*shrugs* I'm not convinced that anyone would ever *not* want to use
--ignore-missing, since programs that use --batch(-check) presumably
query for a large batch of objects and therefore define their own error
handling anyway. Also, it's not like you could accidentally ignore the
"<object> missing" output in your code since you're parsing the output
anyway. So I'm not sure what the point of changing the current behavior
is. (Perhaps add a --exit-on-missing option? Not that I or anyone else
has ever asked for that feature.)
In any case, can please someone review my patch? I think my patch
should be independent of these things (since it's a bug fix), and I'd
hate to see it not make it into the code just because some people don't
seem to like cat-file's behavior. ;-) (I need it for the Perl API,
after all.)
-- Lea
next prev parent reply other threads:[~2008-06-09 13:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 23:28 [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing Lea Wiemann
2008-06-08 23:34 ` Johannes Schindelin
2008-06-09 0:05 ` Lea Wiemann
2008-06-09 1:02 ` Johannes Schindelin
2008-06-09 10:17 ` Lea Wiemann
2008-06-09 11:07 ` Jakub Narebski
2008-06-09 13:27 ` Lea Wiemann [this message]
2008-06-09 0:02 ` [PATCH v2] " Lea Wiemann
2008-06-09 20:37 ` Junio C Hamano
2008-06-09 20:42 ` Junio C Hamano
2008-06-09 14:23 ` [PATCH] " Johannes Sixt
2008-06-09 18:21 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D2FBA.1010606@gmail.com \
--to=lewiemann@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).