git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Clark Williams <clark.williams@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>, git@vger.kernel.org
Subject: Re: [StGit PATCH] compressed import v3
Date: Fri, 13 Jun 2008 09:53:49 -0500	[thread overview]
Message-ID: <485289FD.50808@gmail.com> (raw)
In-Reply-To: <20080613051127.GA24245@diana.vm.bytemark.co.uk>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Karl Hasselström wrote:
> On 2008-06-12 16:32:50 -0500, Clark Williams wrote:
> 
>> Attached is my latest stab at StGit importing patches from
>> compressed files. This version doesn't try to differentiate by the
>> file extension; it just tries to open gzip or bz2 files and if those
>> fail it reverts to text.
> 
> Very good!
> 
>> I'm not completely happy with it, but I've spent about as much time
>> on it as I can afford to (for this week anyway).
> 
> Heh. I see an opportunity for condensing the code a bit in
> __gethandleandname(), and you intented the "pass"es funny, but I'll
> take care of it (or not, seeing as they're kind of minor nits -- in
> any case, I'll just take the patch off your hands and stop tormenting
> you about it).
> 

Ugh, I missed that on the pass'es. I had some other logic in there, attempting to
make sure that the IOError was in fact because the input was uncompressed, but I
punted that and forgot to unindent the pass. I can't believe emacs didn't catch that
for me :)

I'm interested to hear how you'd condense the code in __gethandleandname().

Clark

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkhSif0ACgkQqA4JVb61b9dA1gCeMVvcY4GobZLp+k7qskLVgozN
vsAAmQFoTxf2xxohyzCnCrRQRs1Gdf+O
=lBEr
-----END PGP SIGNATURE-----

  reply	other threads:[~2008-06-13 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 21:32 [StGit PATCH] compressed import v3 Clark Williams
2008-06-13  5:11 ` Karl Hasselström
2008-06-13 14:53   ` Clark Williams [this message]
2008-06-14 10:26     ` Karl Hasselström
2008-06-14 15:49       ` Clark Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485289FD.50808@gmail.com \
    --to=clark.williams@gmail.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).