git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Zawirski <marek.zawirski@gmail.com>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [EGIT RFC] Commit behaviour
Date: Sat, 14 Jun 2008 00:07:59 +0200	[thread overview]
Message-ID: <4852EFBF.6000406@gmail.com> (raw)
In-Reply-To: <1213313997-1520-1-git-send-email-robin.rosenberg@dewire.com>

Robin Rosenberg wrote:
> I got annoyed about having change my selection to a project to be able
> to commit. This tentative feature allows me to hit the commit button
> when any resource is selected and figure out which resources have been
> modified. This makes it much easier to commit. Only the toolbar commit
> is affected for now.

That's a nice idea! I also thought about that one day, as such feature 
already exists in (e.g.) Subclipse that I was used to.

> 
> Another twist would be to list all changed resources, but only enable
> the selected ones, or only the ones in in the same projects as the selected
> resources. Comments?

I think that only selected && changed ones should be listed. When user 
selects explicitly some resources, he/she is probably interested only in 
these ones. And he/she probably did it for easier selection than from 
list of all changed resources, isn't it?

> Code is not efficient either. This is question about the user interface.

Theses patches don't work for me however :/ When I introduce some change 
to a resource/file, even add it to index and click commit (toolbar or 
menu), commit action does nothing. It is - nothing happens. Can you 
reproduce this problem, or should I debug it on my instance? Or do I use 
it in some wrong way?


> Then we could ask ourselved, should we do something similar for Checkout
> and reset too? I think that is not as important as those operations are
> much less frequent.
> 
> -- robin

Well, I think that checkout (maybe reset too) would be useful too - to 
revert some file quickly.

-- 
Marek Zawirski [zawir]
marek.zawirski@gmail.com

  parent reply	other threads:[~2008-06-13 22:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 23:39 [EGIT RFC] Commit behaviour Robin Rosenberg
2008-06-12 23:39 ` [EGIT RFC] Add utilities for figuring out repositories for selected resources Robin Rosenberg
2008-06-12 23:39   ` [EGIT RFC] Enable commit for any resource in a Git-shared project Robin Rosenberg
2008-06-13 22:07 ` Marek Zawirski [this message]
2008-06-13 22:41   ` [EGIT RFC] Commit behaviour Marek Zawirski
2008-06-14  8:40     ` Robin Rosenberg
2008-06-14 10:05       ` Robin Rosenberg
2008-06-14  9:08   ` Robin Rosenberg
2008-06-14 10:23   ` Robin Rosenberg
2008-06-15  2:00     ` Marek Zawirski
2008-06-16  2:11 ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4852EFBF.6000406@gmail.com \
    --to=marek.zawirski@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg@dewire.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).