From: Clark Williams <clark.williams@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>, git@vger.kernel.org
Subject: Re: [StGit PATCH] compressed import v3
Date: Sat, 14 Jun 2008 10:49:03 -0500 [thread overview]
Message-ID: <4853E86F.1050504@gmail.com> (raw)
In-Reply-To: <20080614102646.GD14282@diana.vm.bytemark.co.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Karl Hasselström wrote:
> On 2008-06-13 09:53:49 -0500, Clark Williams wrote:
>
>> I'm interested to hear how you'd condense the code in
>> __gethandleandname().
>
> Like this, for example:
>
> import bz2, gzip
> for copen, ext in [(gzip.open, '.gz'), (bz2.BZ2File, '.bz2')]:
> try:
> f = copen(filename)
> f.read(1)
> f.seek(0)
> return (f, __mkpatchname(filename, ext))
> except IOError, e:
> pass
>
> If you don't mind, I'll just fix that up directly in your patch. (I
> also took the liberty to rename the function to __get_handle_and_name,
> since that's more consistent with other functions in that file.)
>
Ah, that's very nice. Your changes work for me.
Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkhT6G8ACgkQqA4JVb61b9cCeQCfedD0BjOeRa3sbGvkRNe2BPMq
6roAoJE7klMbgymRCJ3B+pEjzgnTWO2l
=uZ+n
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2008-06-14 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 21:32 [StGit PATCH] compressed import v3 Clark Williams
2008-06-13 5:11 ` Karl Hasselström
2008-06-13 14:53 ` Clark Williams
2008-06-14 10:26 ` Karl Hasselström
2008-06-14 15:49 ` Clark Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4853E86F.1050504@gmail.com \
--to=clark.williams@gmail.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).