From: Johannes Sixt <j.sixt@viscovery.net>
To: Git Mailing List <git@vger.kernel.org>
Subject: Re: git diff --cc bug
Date: Mon, 16 Jun 2008 13:48:33 +0200 [thread overview]
Message-ID: <48565311.9070407@viscovery.net> (raw)
In-Reply-To: <48510CFA.3060101@viscovery.net>
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
Johannes Sixt schrieb:
> @@@ -635,31 -865,171 +641,169 @@@ void CValuesView::EraseVa...
> -LRESULT CValuesView::OnOptionsChanged(WPARAM, LPARAM)
> -{
> - if (GetDocument()->ShowPointerValues()) {
> - // invalidate values in the display
> - CPoint pt(m_x, m_y); // will be erased
> - InvalidateValues();
> - FindFmtStrings();
> - Update(pt.x, pt.y);
> - }
> - return 0;
> -}
> -
> void CValuesView::OnUpdate(CView* pSender, LPARAM lHint, ...
> {
> switch (lHint) {
> ++<<<<<<< HEAD:SomUI/ValuesWnd.cpp
> ++=======
> + case UPDATE_MONITORFRAME:
> + {
> (hunk truncated for exposition)
>
> Notice that there are no context lines at the beginning of the second
> hunk. I would not have expected this, and I think it's a bug in git diff.
Attached is a tar.gz of a repository the exposes the bug when a simple
'git diff' is run. If -U2 is added, the removals at the beginning of the
hunk are not shown, as expected. If -U4 is added, more changes are shown
at the beginning of the hunk, which happen to be separated by 3 lines of
context from the part that is unexpectedly visible with -U3.
-- Hannes
[-- Attachment #2: git-diff-cc-bug.tar.gz --]
[-- Type: application/gzip, Size: 3183 bytes --]
next prev parent reply other threads:[~2008-06-16 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 11:48 git diff --cc bug Johannes Sixt
2008-06-16 11:48 ` Johannes Sixt [this message]
2008-06-19 6:54 ` Junio C Hamano
2008-06-19 8:11 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48565311.9070407@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).