git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lea Wiemann <lewiemann@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] test-lib.sh: add --long-tests option
Date: Tue, 17 Jun 2008 09:09:57 +0200	[thread overview]
Message-ID: <48576345.7000809@gmail.com> (raw)
In-Reply-To: <7vy7547egk.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> I am guessing that the reason why you do not unset GIT_TEST_LONG upfront
> in the script is because the user can do:
> 
>         $ GIT_TEST_LONG=t; export GIT_TEST_LONG
>         $ ./t9999-this-test.sh
>         $ ./t9999-that-test.sh
> 
> or even:
> 
> 	$ GIT_TEST_LONG=t make test

Yes, that's the idea.

> If that is the case, however, I wonder if this --long-tests option is even
> necessary.

It's very convenient for development, where you go back and forth 
between "./t9503-gitweb-Mechanize.sh -v -l" and 
"./t9503-gitweb-Mechanize.sh -v".  All it takes is to add or remove the 
"-l" at each invocation.  So I think the switch is actually quite useful.

-- Lea

  reply	other threads:[~2008-06-17  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17  1:29 [PATCH] test-lib.sh: add --long-tests option Lea Wiemann
2008-06-17  6:39 ` Junio C Hamano
2008-06-17  7:09   ` Lea Wiemann [this message]
2008-06-17  7:15     ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2008-06-17  6:26 Lea Wiemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48576345.7000809@gmail.com \
    --to=lewiemann@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).