git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [JGIT] fnmatch Implementation.
@ 2008-06-18 10:12 Florian Köberle
  2008-06-18 18:43 ` Robin Rosenberg
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Köberle @ 2008-06-18 10:12 UTC (permalink / raw)
  To: git; +Cc: Robin Rosenberg, galder.zamarreno, Shawn O. Pearce

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

when I send a large list of patches and one is wrong then you don't
accept any. That's why I now will try to get one patch in before I send
the next one.

The first patch I will commit this way is the fnmatch patch.

As suggested by Robin I replaced unicode characters not included in the
ASCII set with \uXXXX sequences.

I also added some more test cases and improved the javadoc of the
FileNameMatcher class.

Best regards,
Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIWN+i59ca4mzhfxMRAu8oAJ44Vjp0jvzfjRPRqVoDsUyypNVbvQCgoZRX
GK9kaAlh+Zu3nFen30tc7Rc=
=pvuB
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [JGIT] fnmatch Implementation.
  2008-06-18 10:12 [JGIT] fnmatch Implementation Florian Köberle
@ 2008-06-18 18:43 ` Robin Rosenberg
  0 siblings, 0 replies; 2+ messages in thread
From: Robin Rosenberg @ 2008-06-18 18:43 UTC (permalink / raw)
  To: Florian Köberle; +Cc: git, galder.zamarreno, Shawn O. Pearce

onsdagen den 18 juni 2008 12.12.50 skrev Florian Köberle:
> Hi,
> 
> when I send a large list of patches and one is wrong then you don't
> accept any. That's why I now will try to get one patch in before I send
> the next one.
Patience please. When there is long series it *will* take time for
a number of reasons. Most have nothing to do with this project at all. But in
general you will  find a short patch series  *much* easier to get through than 
a long one.

If you think my grouping is ok, then ack and I can commit from there. I
was thinking of actually adding some test myself, but that's all I had in mind.

> The first patch I will commit this way is the fnmatch patch.
> 
> As suggested by Robin I replaced unicode characters not included in the
> ASCII set with \uXXXX sequences.
> 
> I also added some more test cases and improved the javadoc of the
> FileNameMatcher class.
That's good.

> 
> Best regards,
> Florian
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-06-18 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-18 10:12 [JGIT] fnmatch Implementation Florian Köberle
2008-06-18 18:43 ` Robin Rosenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).