From: Olivier Marin <dkr+ml.git@free.fr>
To: Lea Wiemann <lewiemann@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] t/test-lib.sh: add test_external and test_external_without_stderr
Date: Wed, 18 Jun 2008 22:24:07 +0200 [thread overview]
Message-ID: <48596EE7.90202@free.fr> (raw)
In-Reply-To: <d94c2a62edfdec22c32ef5d9649078430b30ecfd.1213685306.git.LeWiemann@gmail.com>
Hi,
Lea Wiemann a écrit :
> +# Like test_external, but in addition tests that the command generated
> +# no output on stderr.
> +test_external_without_stderr () {
> + # The temporary file has no (and must have no) security
> + # implications.
> + tmp="$TMPDIR"; if [ -z "$tmp" ]; then tmp=/tmp; fi
> + stderr="$tmp/git-external-stderr.$$.tmp"
> + test_external "$@" 4> "$stderr"
> + [ -f "$stderr" ] || eror "Internal error: $stderr disappeared."
Just a typo here: s/eror/error/
Olivier.
next prev parent reply other threads:[~2008-06-18 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 6:59 [PATCH 1/2 v2] t/test-lib.sh: add test_external and test_external_without_stderr Lea Wiemann
2008-06-17 6:59 ` [PATCH 2/2 v4] Git.pm: add test suite Lea Wiemann
2008-06-18 3:16 ` Junio C Hamano
2008-06-18 18:04 ` Lea Wiemann
2008-06-18 19:40 ` Junio C Hamano
2008-06-18 20:32 ` Olivier Marin
2008-06-18 20:24 ` Olivier Marin [this message]
2008-06-19 18:18 ` [PATCH 1/2 v3] t/test-lib.sh: add test_external and test_external_without_stderr Lea Wiemann
2008-06-19 18:18 ` [PATCH 2/2 v5] Git.pm: add test suite Lea Wiemann
2008-06-19 20:32 ` Lea Wiemann
2008-06-19 20:53 ` Jakub Narebski
2008-06-19 20:55 ` Lea Wiemann
2008-06-19 23:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48596EE7.90202@free.fr \
--to=dkr+ml.git@free.fr \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).