From: Lea Wiemann <lewiemann@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2 v5] Git.pm: add test suite
Date: Thu, 19 Jun 2008 22:55:36 +0200 [thread overview]
Message-ID: <485AC7C8.5040100@gmail.com> (raw)
In-Reply-To: <m3lk11m9j7.fsf@localhost.localdomain>
Jakub Narebski wrote:
> Lea Wiemann <lewiemann@gmail.com> writes:
>> +use 5.006002; # Test::More was introduced in 5.6.2
>
> Isn't "use Test::More" enough, so this line is not strictly
> necessary?
I'd prefer to have a 'wrong Perl version' error instead of 'module not
found'. Also it's good to document what we support, to remind me that I
have to run it with perl5.6.
-- Lea
next prev parent reply other threads:[~2008-06-19 20:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 6:59 [PATCH 1/2 v2] t/test-lib.sh: add test_external and test_external_without_stderr Lea Wiemann
2008-06-17 6:59 ` [PATCH 2/2 v4] Git.pm: add test suite Lea Wiemann
2008-06-18 3:16 ` Junio C Hamano
2008-06-18 18:04 ` Lea Wiemann
2008-06-18 19:40 ` Junio C Hamano
2008-06-18 20:32 ` Olivier Marin
2008-06-18 20:24 ` [PATCH 1/2 v2] t/test-lib.sh: add test_external and test_external_without_stderr Olivier Marin
2008-06-19 18:18 ` [PATCH 1/2 v3] " Lea Wiemann
2008-06-19 18:18 ` [PATCH 2/2 v5] Git.pm: add test suite Lea Wiemann
2008-06-19 20:32 ` Lea Wiemann
2008-06-19 20:53 ` Jakub Narebski
2008-06-19 20:55 ` Lea Wiemann [this message]
2008-06-19 23:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485AC7C8.5040100@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).