From: Johannes Sixt <j.sixt@viscovery.net>
To: Richard Quirk <richard.quirk@gmail.com>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] git-gui: Fix accidental staged state toggle when clicking top pixel row
Date: Fri, 20 Jun 2008 17:26:48 +0200 [thread overview]
Message-ID: <485BCC38.1000403@viscovery.net> (raw)
In-Reply-To: <1213973895-10264-1-git-send-email-richard.quirk@gmail.com>
Richard Quirk schrieb:
> If a text widget is asked the index at x,y with y == 0 or y == 1 it will
> always return 1.0 as the nearest index, regardless of the x position.
>
> This means that clicking the top 2 pixels of the Unstaged/Staged Changes
> lists caused the state of the file there to be toggled. This patch
> checks that the pixel clicked is greater than 1, so there is less chance
> of accidentally staging or unstaging changes.
Ah, that would explain why it sometimes happened that a file was staged
even though the mouse pointer was no where near the icon!
-- Hannes
next prev parent reply other threads:[~2008-06-20 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 14:58 [PATCH] git-gui: Fix accidental staged state toggle when clicking top pixel row Richard Quirk
2008-06-20 15:26 ` Johannes Sixt [this message]
2008-06-21 3:21 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485BCC38.1000403@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=richard.quirk@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).