From: Lea Wiemann <lewiemann@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: gitweb: Broken links in blame view
Date: Sun, 22 Jun 2008 23:37:37 +0200 [thread overview]
Message-ID: <485EC621.7090101@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
Hi!
I (or rather, the link checker) has discovered another broken link, this
time in gitweb's blame view, which happens if you blame files and it
tries to get parents before the initial (first) commit in the repository:
1. Unpack test.git.tar.gz (attached) into gitweb's project root.
2. Make sure $feature{'blame'}{'default'} = [1]; is on in
gitweb_config.perl.
3. Open the following page:
http://localhost/.../gitweb.cgi?p=test.git;a=blame;f=file;h=f8c58d2c88cbcf660f473f8f123ee32db0d0d2be;hb=HEAD
4. Click the gray "1" line number -- you get a "400 - Invalid hash base
parameter" response (or '403' instead of 400 if you're not on next).
(I've also reproduced this with gitweb revisions from 7 months ago, so
it's not related to recent changes.)
Also, probably related, if you open the above blame view by calling
gitweb.cgi on the command line, you'll see a bogus error message on
STDERR: "fatal: ambiguous argument 'f891e539f...^': unknown revision"
Note that f891... is the earliest revision in the repository.
-- Lea
[-- Attachment #2: test.git.tar.gz --]
[-- Type: application/gzip, Size: 9074 bytes --]
reply other threads:[~2008-06-22 21:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485EC621.7090101@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).